New patch to review for coreboot: c2e50ec Use fast memset in SMM mode, too

[Stefan Reinauer]

Stefan Reinauer ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/827

-gerrit

commit c2e50ece4dec0fbfdc714b171530a658b8d8d13a
Author: Stefan Reinauer <[e-mail]>
Date:   Fri Mar 30 16:28:20 2012 -0700

    Use fast memset in SMM mode, too
    
    ... and always include IP checksumming in romstage.
    It's generally useful and our upcoming port needs it.
    
    Change-Id: I248402d96a23e58354744e053b9d5cca6b74ad3a
    Signed-off-by: Stefan Reinauer <[e-mail]>
---
 src/arch/x86/lib/Makefile.inc |    1 +
 src/lib/Makefile.inc          |    8 ++++++--
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/arch/x86/lib/Makefile.inc b/src/arch/x86/lib/Makefile.inc
index 8f5fd5f..4375952 100644
--- a/src/arch/x86/lib/Makefile.inc
+++ b/src/arch/x86/lib/Makefile.inc
@@ -15,6 +15,7 @@ romstage-y += cbfs_and_run.c
 romstage-y += memset.c
 romstage-y += memcpy.c
 
+smm-y += memset.c
 smm-y += memcpy.c
 
 $(obj)/arch/x86/lib/console.ramstage.o :: $(obj)/build.h
diff --git a/src/lib/Makefile.inc b/src/lib/Makefile.inc
index 8ce72b2..7c081ac 100644
--- a/src/lib/Makefile.inc
+++ b/src/lib/Makefile.inc
@@ -17,9 +17,10 @@ romstage-$(CONFIG_CONSOLE_SERIAL8250) += uart8250.c
 romstage-$(CONFIG_CONSOLE_SERIAL8250MEM) += uart8250mem.c
 romstage-$(CONFIG_CONSOLE_CBMEM) += cbmem_console.c
 romstage-$(CONFIG_CONSOLE_NE2K) += ne2k.c
-romstage-$(CONFIG_CONSOLE_NE2K) += compute_ip_checksum.c
 romstage-$(CONFIG_USBDEBUG) += usbdebug.c
 romstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c
+romstage-y += compute_ip_checksum.c
+romstage-y += memmove.c
 
 ifneq ($(CONFIG_HAVE_ARCH_MEMSET),y)
 ramstage-y += memset.c
@@ -51,10 +52,13 @@ ramstage-$(CONFIG_COLLECT_TIMESTAMPS) += timestamp.c
 
 driver-$(CONFIG_CONSOLE_NE2K) += ne2k.c
 
+ifneq ($(CONFIG_HAVE_ARCH_MEMSET),y)
+smm-y += memset.c
+endif
 ifneq ($(CONFIG_HAVE_ARCH_MEMCPY),y)
 smm-y += memcpy.c
 endif
-smm-y += cbfs.c memset.c memcmp.c
+smm-y += cbfs.c memcmp.c
 smm-$(CONFIG_CONSOLE_SERIAL8250) += uart8250.c
 smm-$(CONFIG_CONSOLE_SERIAL8250MEM) += uart8250mem.c
 smm-$(CONFIG_USBDEBUG) += usbdebug.c

New patch to review for coreboot: c2e50ec Use fast memset in SMM mode, too

[Peter Stuge]

Stefan Reinauer wrote:
> ... and always include IP checksumming in romstage.
>     It's generally useful and our upcoming port needs it.

I don't know.. Why add code which in most cases isn't being used.
We've created a fairly elaborate and powerful build system
specifically to avoid this, and you ignore it because of "useful" ?

Just add a config for the code instead, and only select where it is
actually being used.


//Peter

New patch to review for coreboot: c2e50ec Use fast memset in SMM mode, too

[Patrick Georgi]

Am 04.04.2012 19:51, schrieb Peter Stuge:
> Stefan Reinauer wrote:
> > ... and always include IP checksumming in romstage. It's generally
> > useful and our upcoming port needs it.
> > I don't know.. Why add code which in most cases isn't being used. 
> > We've created a fairly elaborate and powerful build system 
> > specifically to avoid this, and you ignore it because of "useful" ?
> > The linker should kick it out again. I oppose having a config flag for
> > every single source file.

Patrick

New patch to review for coreboot: c2e50ec Use fast memset in SMM mode, too

[ron minnich]

On Wed, Apr 4, 2012 at 10:53 AM, Patrick Georgi <[e-mail]> wrote:
> The linker should kick it out again. I oppose having a config flag for
> every single source file.

by analogy, there is a huge amount of code compiled into glibc that I
don't use. It's the compilers/linkers job to not build in those things
I don't need, even if I compile them. I agree with patrick and stefan
on this one.

ron