[RFH] Test Lenovo X230 with master?
Dear coreboot folks, In #coreboot@irc.libera.chat a user reported, that flashing coreboot built from master (commit aa8b1f8b38 (mb/system76: Configure I2C HID IRQs as level triggered)) to SPI2 does not boot.
Display black but lit, no display output. I don't have coreboot logs. Blinking power button + micmute button.
Unfortunately, the user does not have any equipment to get any logs, and SPI flash console is not supported. Could somebody with such equipment please verify, and provide the logs? Kind regards, Paul PS: `defconfig`: ``` CONFIG_VENDOR_LENOVO=y CONFIG_CBFS_SIZE=0x400000 CONFIG_LINEAR_FRAMEBUFFER_MAX_HEIGHT=1600 CONFIG_LINEAR_FRAMEBUFFER_MAX_WIDTH=2560 CONFIG_CONSOLE_CBMEM_BUFFER_SIZE=0x20000 CONFIG_HAVE_IFD_BIN=y CONFIG_PCIEXP_HOTPLUG_BUSES=8 CONFIG_PCIEXP_HOTPLUG_MEM=0x800000 CONFIG_PCIEXP_HOTPLUG_PREFETCH_MEM=0x10000000 CONFIG_BOARD_LENOVO_X230=y CONFIG_UART_PCI_ADDR=0x0 CONFIG_VALIDATE_INTEL_DESCRIPTOR=y CONFIG_H8_SUPPORT_BT_ON_WIFI=y CONFIG_HAVE_ME_BIN=y CONFIG_CHECK_ME=y CONFIG_USE_ME_CLEANER=y CONFIG_HAVE_GBE_BIN=y CONFIG_LOCK_MANAGEMENT_ENGINE=y CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y CONFIG_PCIEXP_HOTPLUG_IO=0x2000 CONFIG_SUBSYSTEM_VENDOR_ID=0x0000 CONFIG_SUBSYSTEM_DEVICE_ID=0x0000 CONFIG_I2C_TRANSFER_TIMEOUT_US=500000 CONFIG_POST_IO_PORT=0x80 CONFIG_PAYLOAD_GRUB2=y CONFIG_GRUB2_REVISION=y CONFIG_GRUB2_REVISION_ID="grub-2.06" CONFIG_GRUB2_EXTRA_MODULES="nativedisk crypto cryptodisk luks luks2 gcry_serpent gcry_twofish gcry_rijndael gcry_sha1 gcry_sha256 gcry_sha512 gcry_crc password_pbkdf2 part_gpt btrfs cat bsd png gfxterm_background all_video usbserial_ftdi usbserial_pl2303" CONFIG_COREINFO_SECONDARY_PAYLOAD=y CONFIG_MEMTEST_SECONDARY_PAYLOAD=y CONFIG_NVRAMCUI_SECONDARY_PAYLOAD=y ```
Thanks Paul. I'm the user who reported this on IRC. Currently trying to bisect this. I want to note that I was using a very similar config (without CONFIG_H8_SUPPORT_BT_ON_WIFI=y) with coreboot 4.13 on the same X230, and that ran fine (and still runs fine, if I reflash it). Will post any results here. Merlin On Tue, 3 May 2022 14:46:48 +0200, Paul Menzel wrote:
Dear coreboot folks,
In #coreboot@irc.libera.chat a user reported, that flashing coreboot built from master (commit aa8b1f8b38 (mb/system76: Configure I2C HID IRQs as level triggered)) to SPI2 does not boot.
Display black but lit, no display output. I don't have coreboot logs. Blinking power button + micmute button.
Unfortunately, the user does not have any equipment to get any logs, and SPI flash console is not supported.
Could somebody with such equipment please verify, and provide the logs?
Kind regards,
Paul
PS: `defconfig`:
``` CONFIG_VENDOR_LENOVO=y CONFIG_CBFS_SIZE=0x400000 CONFIG_LINEAR_FRAMEBUFFER_MAX_HEIGHT=1600 CONFIG_LINEAR_FRAMEBUFFER_MAX_WIDTH=2560 CONFIG_CONSOLE_CBMEM_BUFFER_SIZE=0x20000 CONFIG_HAVE_IFD_BIN=y CONFIG_PCIEXP_HOTPLUG_BUSES=8 CONFIG_PCIEXP_HOTPLUG_MEM=0x800000 CONFIG_PCIEXP_HOTPLUG_PREFETCH_MEM=0x10000000 CONFIG_BOARD_LENOVO_X230=y CONFIG_UART_PCI_ADDR=0x0 CONFIG_VALIDATE_INTEL_DESCRIPTOR=y CONFIG_H8_SUPPORT_BT_ON_WIFI=y CONFIG_HAVE_ME_BIN=y CONFIG_CHECK_ME=y CONFIG_USE_ME_CLEANER=y CONFIG_HAVE_GBE_BIN=y CONFIG_LOCK_MANAGEMENT_ENGINE=y CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y CONFIG_PCIEXP_HOTPLUG_IO=0x2000 CONFIG_SUBSYSTEM_VENDOR_ID=0x0000 CONFIG_SUBSYSTEM_DEVICE_ID=0x0000 CONFIG_I2C_TRANSFER_TIMEOUT_US=500000 CONFIG_POST_IO_PORT=0x80 CONFIG_PAYLOAD_GRUB2=y CONFIG_GRUB2_REVISION=y CONFIG_GRUB2_REVISION_ID="grub-2.06" CONFIG_GRUB2_EXTRA_MODULES="nativedisk crypto cryptodisk luks luks2 gcry_serpent gcry_twofish gcry_rijndael gcry_sha1 gcry_sha256 gcry_sha512 gcry_crc password_pbkdf2 part_gpt btrfs cat bsd png gfxterm_background all_video usbserial_ftdi usbserial_pl2303" CONFIG_COREINFO_SECONDARY_PAYLOAD=y CONFIG_MEMTEST_SECONDARY_PAYLOAD=y CONFIG_NVRAMCUI_SECONDARY_PAYLOAD=y ``` _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
-- Merlin Büge
Hi, so I have found that on the X230, current master
commit aa8b1f8b38bf1abcb6dd8c6f5f510c3006d0eec6 mb/system76: Configure I2C HID IRQs as level triggered
works with SeaBIOS 1.16 and GRUB 2.04, but not with GRUB 2.06. Attached is a defconfig that works. If I add these two lines, I get the issue described in the original post:
CONFIG_GRUB2_REVISION=y CONFIG_GRUB2_REVISION_ID="grub-2.06"
I just found this, it's probably the issue described there: https://review.coreboot.org/c/coreboot/+/55343 Sorry for the noise! Merlin On Tue, 3 May 2022 14:46:48 +0200, Paul Menzel wrote:
Dear coreboot folks,
In #coreboot@irc.libera.chat a user reported, that flashing coreboot built from master (commit aa8b1f8b38 (mb/system76: Configure I2C HID IRQs as level triggered)) to SPI2 does not boot.
Display black but lit, no display output. I don't have coreboot logs. Blinking power button + micmute button.
Unfortunately, the user does not have any equipment to get any logs, and SPI flash console is not supported.
Could somebody with such equipment please verify, and provide the logs?
Kind regards,
Paul
PS: `defconfig`:
``` CONFIG_VENDOR_LENOVO=y CONFIG_CBFS_SIZE=0x400000 CONFIG_LINEAR_FRAMEBUFFER_MAX_HEIGHT=1600 CONFIG_LINEAR_FRAMEBUFFER_MAX_WIDTH=2560 CONFIG_CONSOLE_CBMEM_BUFFER_SIZE=0x20000 CONFIG_HAVE_IFD_BIN=y CONFIG_PCIEXP_HOTPLUG_BUSES=8 CONFIG_PCIEXP_HOTPLUG_MEM=0x800000 CONFIG_PCIEXP_HOTPLUG_PREFETCH_MEM=0x10000000 CONFIG_BOARD_LENOVO_X230=y CONFIG_UART_PCI_ADDR=0x0 CONFIG_VALIDATE_INTEL_DESCRIPTOR=y CONFIG_H8_SUPPORT_BT_ON_WIFI=y CONFIG_HAVE_ME_BIN=y CONFIG_CHECK_ME=y CONFIG_USE_ME_CLEANER=y CONFIG_HAVE_GBE_BIN=y CONFIG_LOCK_MANAGEMENT_ENGINE=y CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y CONFIG_PCIEXP_HOTPLUG_IO=0x2000 CONFIG_SUBSYSTEM_VENDOR_ID=0x0000 CONFIG_SUBSYSTEM_DEVICE_ID=0x0000 CONFIG_I2C_TRANSFER_TIMEOUT_US=500000 CONFIG_POST_IO_PORT=0x80 CONFIG_PAYLOAD_GRUB2=y CONFIG_GRUB2_REVISION=y CONFIG_GRUB2_REVISION_ID="grub-2.06" CONFIG_GRUB2_EXTRA_MODULES="nativedisk crypto cryptodisk luks luks2 gcry_serpent gcry_twofish gcry_rijndael gcry_sha1 gcry_sha256 gcry_sha512 gcry_crc password_pbkdf2 part_gpt btrfs cat bsd png gfxterm_background all_video usbserial_ftdi usbserial_pl2303" CONFIG_COREINFO_SECONDARY_PAYLOAD=y CONFIG_MEMTEST_SECONDARY_PAYLOAD=y CONFIG_NVRAMCUI_SECONDARY_PAYLOAD=y ``` _______________________________________________ coreboot mailing list -- coreboot@coreboot.org To unsubscribe send an email to coreboot-leave@coreboot.org
-- Merlin Büge
I just found this, it's probably the issue described there: https://review.coreboot.org/c/coreboot/+/55343
Turns out there's a patch submitted that works around the issue: https://review.coreboot.org/c/coreboot/+/64235 I've tested it and it works :) Felix Freeman
Hi Felix, On Fri, 24 Jun 2022 11:43:19 -0400, Felix Freeman wrote:
I just found this, it's probably the issue described there: https://review.coreboot.org/c/coreboot/+/55343
Turns out there's a patch submitted that works around the issue: https://review.coreboot.org/c/coreboot/+/64235
I've tested it and it works :)
Thanks for the hint! That also worked for me, it's how I worked around the issue a few weeks ago (with help from the friendly IRC channel :). I can confirm it works with coreboot 4.16-838-gaa8b1f8b38. Merlin -- Merlin Büge
participants (3)
-
Felix Freeman -
Merlin Büge -
Paul Menzel