what was I thinking with that earlier patch? Don't do things when so distracted. Now I have to run and do some things.
Rename log2 to log2c (ceiling) and add log2f (floor). People need to be aware of what they are doing with log2, it is easy to make a mistake.
This is a proposal, as it will break a (very) few things, the rewrite is trivial, pick the right log2 function, but I got bit by the fact that log2 as written has assumptions that don't meet all needs.
ron
On 31.08.2008 18:59, ron minnich wrote:
what was I thinking with that earlier patch? Don't do things when so distracted. Now I have to run and do some things.
Rename log2 to log2c (ceiling) and add log2f (floor). People need to be aware of what they are doing with log2, it is easy to make a mistake.
This is a proposal, as it will break a (very) few things, the rewrite is trivial, pick the right log2 function, but I got bit by the fact that log2 as written has assumptions that don't meet all needs.
Impressive spotting.
Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
Regards, Carl-Daniel
-
Carl-Daniel Hailfinger -
ron minnich