Re: [coreboot] Status Thinkpad T410
ok the problems start when i try to merge the patch found on https://review.coreboot.org/c/coreboot/+/11791 into a coreboot master clone ... any guide? i am not that advanced in git Am 08.11.18 um 17:40 schrieb Mike Banon:
Go to review.coreboot.org, search for the recently updated T410 patches and apply them to your locally cloned coreboot, then build and test it. Let us know if you have a trouble at any step On Thu, Nov 8, 2018 at 7:35 PM kinky_nekoboi <kinky_nekoboi@bluetardis.de> wrote:
I have hardware to test, T410 with intel gpu + little flashing tool collection. i am waiting for instructions
Am 8. November 2018 17:30:00 MEZ schrieb Peter Lemenkov <lemenkov@gmail.com>:
Hello!
чт, 8 нояб. 2018 г. в 10:50, Angel Pons <th3fanbus@gmail.com>:
Hello nekoboi,
On Thu, Nov 8, 2018, 10:39 kinky_nekoboi <kinky_nekoboi@bluetardis.de wrote:
is there any work going on in the T410 Port ?
Hardware is simular to X201
I heard some people succesfully flashed x201 roms.
I recall seeing a gerrit patch for it, though it is old. I would work on it but I don't have any Thinkpad (let alone a T410).
Btw I've updated recently both t410 and t410s patches from gerrit according to the recent coreboot changes, but I've got the same story - I don't have hardware to test.
-- coreboot mailing list: coreboot@coreboot.org https://mail.coreboot.org/mailman/listinfo/coreboot
ok this issue was caused by a merge conflict... i downloaded the tar file and extracted it. compilation fails with: src/mainboard/lenovo/t410/romstage.c:320:2: error: implicit declaration of function 'init_tpm' [-Werror=implicit-function-declaration] init_tpm(s3resume); ^~~~~~~~ CC romstage/northbridge/intel/nehalem/raminit.o CC romstage/southbridge/intel/bd82x6x/early_me.o CC romstage/southbridge/intel/bd82x6x/early_rcba.o cc1: all warnings being treated as errors make: *** [Makefile:338: build/romstage/mainboard/lenovo/t410/romstage.o] Fehler 1 Am 08.11.18 um 20:29 schrieb kinky_nekoboi: > ok the problems start when i try to merge the patch found on > > https://review.coreboot.org/c/coreboot/+/11791 > > into a coreboot master clone ... > > any guide? i am not that advanced in git > > Am 08.11.18 um 17:40 schrieb Mike Banon: >> Go to review.coreboot.org, search for the recently updated T410 >> patches and apply them to your locally cloned coreboot, then build and >> test it. Let us know if you have a trouble at any step >> On Thu, Nov 8, 2018 at 7:35 PM kinky_nekoboi >> <kinky_nekoboi@bluetardis.de> wrote: >>> I have hardware to test, >>> T410 with intel gpu + little flashing tool collection. >>> i am waiting for instructions >>> >>> Am 8. November 2018 17:30:00 MEZ schrieb Peter Lemenkov <lemenkov@gmail.com>: >>>> Hello! >>>> >>>> чт, 8 нояб. 2018 г. в 10:50, Angel Pons <th3fanbus@gmail.com>: >>>>> Hello nekoboi, >>>>> >>>>> On Thu, Nov 8, 2018, 10:39 kinky_nekoboi <kinky_nekoboi@bluetardis.de wrote: >>>>>> is there any work going on in the T410 Port ? >>>>>> >>>>>> Hardware is simular to X201 >>>>>> >>>>>> I heard some people succesfully flashed x201 roms. >>>>> >>>>> I recall seeing a gerrit patch for it, though it is old. I would work on it but I don't have any Thinkpad (let alone a T410). >>>> Btw I've updated recently both t410 and t410s patches from gerrit >>>> according to the recent coreboot changes, but I've got the same story >>>> - I don't have hardware to test. >>>> >>> -- >>> coreboot mailing list: coreboot@coreboot.org >>> https://mail.coreboot.org/mailman/listinfo/coreboot
On 11/8/18 8:41 PM, kinky_nekoboi wrote:
ok this issue was caused by a merge conflict... i downloaded the tar file and extracted it.
You can checkout (not cherry-pick) the patch from Gerrit, then have a look at the following: $ git diff HEAD^..origin/master -- src/mainboard/lenovo/x201/ This should show you the changes that were made to the X201 (closest supported relative) in the meantime. You might have to replicate most (maybe all) of these changes for the T410. Now that I thought about it, you can just look what was the parent of the commit on Gerrit (what I just did) and use that (no need to checkout the commit): $ git diff 2819a40ed3..origin/master -- src/mainboard/lenovo/x201/ Nico
just found out that the author of this patch/port is also german speaking and lifes in the same city area as me. i will mail him, than i dont have to spam this mailing list with my broken english anymore about the T410. Am 08.11.18 um 20:59 schrieb Nico Huber:
On 11/8/18 8:41 PM, kinky_nekoboi wrote:
ok this issue was caused by a merge conflict... i downloaded the tar file and extracted it. You can checkout (not cherry-pick) the patch from Gerrit, then have a look at the following:
$ git diff HEAD^..origin/master -- src/mainboard/lenovo/x201/
This should show you the changes that were made to the X201 (closest supported relative) in the meantime. You might have to replicate most (maybe all) of these changes for the T410.
Now that I thought about it, you can just look what was the parent of the commit on Gerrit (what I just did) and use that (no need to checkout the commit):
$ git diff 2819a40ed3..origin/master -- src/mainboard/lenovo/x201/
Nico
Hey! Please try the latest patch from Gerrit - it should apply and compile cleanly. чт, 8 нояб. 2018 г. в 21:19, kinky_nekoboi <kinky_nekoboi@bluetardis.de>:
just found out that the author of this patch/port is also german speaking and lifes in the same city area as me. i will mail him, than i dont have to spam this mailing list with my broken english anymore about the T410.
Am 08.11.18 um 20:59 schrieb Nico Huber:
On 11/8/18 8:41 PM, kinky_nekoboi wrote:
ok this issue was caused by a merge conflict... i downloaded the tar file and extracted it. You can checkout (not cherry-pick) the patch from Gerrit, then have a look at the following:
$ git diff HEAD^..origin/master -- src/mainboard/lenovo/x201/
This should show you the changes that were made to the X201 (closest supported relative) in the meantime. You might have to replicate most (maybe all) of these changes for the T410.
Now that I thought about it, you can just look what was the parent of the commit on Gerrit (what I just did) and use that (no need to checkout the commit):
$ git diff 2819a40ed3..origin/master -- src/mainboard/lenovo/x201/
Nico
-- coreboot mailing list: coreboot@coreboot.org https://mail.coreboot.org/mailman/listinfo/coreboot
-- With best regards, Peter Lemenkov.
participants (3)
-
kinky_nekoboi -
Nico Huber -
Peter Lemenkov