[Patch] Flashrom: Add gA-k8n-sli board enable.

[Luc Verhaegen]

Still needs to be tested by alexander.

Luc Verhaegen.

[Carl-Daniel Hailfinger]

On 02.06.2009 16:13, Luc Verhaegen wrote:
> Board enable: Gigabyte GA K8N SLI.
>
> Raises bits 0 and 2 on offset 0xE1 in the system control area of the
> nvidia ck804 lpc.
>
> Signed-off-by: Luc Verhaegen

With the comment below addressed, this is
Acked-by: Carl-Daniel Hailfinger
> Index: board_enable.c
>
> --- board_enable.c	(revision 564)
> +++ board_enable.c	(working copy)
> @@ -372,6 +372,31 @@
> base = pci_read_long(dev, 0x64) & 0xFFFFFF00; /* System control area */

base is an I/O port which is restricted to 16 bits on x86 compatible
platforms. Suggestion:

base = pci_read_long(dev, 0x64) & 0x0000FF00;

Regards,
Carl-Daniel

[Luc Verhaegen]

On Tue, Jun 02, 2009 at 04:34:14PM +0200, Carl-Daniel Hailfinger wrote:
> On 02.06.2009 16:13, Luc Verhaegen wrote:
> > Board enable: Gigabyte GA K8N SLI.
> >
> > Raises bits 0 and 2 on offset 0xE1 in the system control area of the
> > nvidia ck804 lpc.
> >
> > Signed-off-by: Luc Verhaegen
>
> With the comment below addressed, this is
> Acked-by: Carl-Daniel Hailfinger
> > Index: board_enable.c
> >
> > --- board_enable.c	(revision 564)
> > +++ board_enable.c	(working copy)
> > @@ -372,6 +372,31 @@
> > base = pci_read_long(dev, 0x64) & 0xFFFFFF00; /* System control area */
>
> base is an I/O port which is restricted to 16 bits on x86 compatible
> platforms. Suggestion:
>
> base = pci_read_long(dev, 0x64) & 0x0000FF00;
>
> Regards,
> Carl-Daniel

Ok!

Still waiting for alexander though,

Luc Verhaegen.

[Alexander Gordeev]

On Tuesday 02 June 2009 18:13:52 Luc Verhaegen wrote:
> Still needs to be tested by alexander.
>
> Luc Verhaegen.

WOW, it is working now! Thanks a lot!

alex@tornado:~/bios$ sudo ../development/flashrom/trunk/flashrom
flashrom v0.9.0-r566
No coreboot table found.
Found chipset "NVIDIA CK804", enabling flash write... OK.
Found board "GIGABYTE GA-K8N-SLI", enabling flash write... OK.
Calibrating delay loop... OK.
Found chip "PMC Pm49FL004" (512 KB) at physical address 0xfff80000.
No operations were specified.

I also tested read, write, erase and verify operations and rebooted the 
machine with the new bios. Everything is ok!

[Alexander Gordeev]

On Tuesday 02 June 2009 22:43:56 Alexander Gordeev wrote:
> On Tuesday 02 June 2009 18:13:52 Luc Verhaegen wrote:
> > Still needs to be tested by alexander.
> >
> > Luc Verhaegen.
>
> WOW, it is working now! Thanks a lot!
>
> alex@tornado:~/bios$ sudo ../development/flashrom/trunk/flashrom
> flashrom v0.9.0-r566
> No coreboot table found.
> Found chipset "NVIDIA CK804", enabling flash write... OK.
> Found board "GIGABYTE GA-K8N-SLI", enabling flash write... OK.
> Calibrating delay loop... OK.
> Found chip "PMC Pm49FL004" (512 KB) at physical address 0xfff80000.
> No operations were specified.
>
> I also tested read, write, erase and verify operations and rebooted the
> machine with the new bios. Everything is ok!

P.S. The flash chip is currently soldered directly on the board but I'm going 
to replace it with a socket so feel free to contact me if you need a tester.

[Alexander Gordeev]

On Tuesday 02 June 2009 22:54:36 Alexander Gordeev wrote:
> On Tuesday 02 June 2009 22:43:56 Alexander Gordeev wrote:
> > On Tuesday 02 June 2009 18:13:52 Luc Verhaegen wrote:
> > > Still needs to be tested by alexander.
> > >
> > > Luc Verhaegen.
> >
> > WOW, it is working now! Thanks a lot!
> >
> > alex@tornado:~/bios$ sudo ../development/flashrom/trunk/flashrom
> > flashrom v0.9.0-r566
> > No coreboot table found.
> > Found chipset "NVIDIA CK804", enabling flash write... OK.
> > Found board "GIGABYTE GA-K8N-SLI", enabling flash write... OK.
> > Calibrating delay loop... OK.
> > Found chip "PMC Pm49FL004" (512 KB) at physical address 0xfff80000.
> > No operations were specified.
> >
> > I also tested read, write, erase and verify operations and rebooted the
> > machine with the new bios. Everything is ok!
>
> P.S. The flash chip is currently soldered directly on the board but I'm
> going to replace it with a socket so feel free to contact me if you need a
> tester.

P.P.S.
Acked-by: Alexander Gordeev

[Luc Verhaegen]

On Tue, Jun 02, 2009 at 10:43:56PM +0400, Alexander Gordeev wrote:
> On Tuesday 02 June 2009 18:13:52 Luc Verhaegen wrote:
> > Still needs to be tested by alexander.
> >
> > Luc Verhaegen.
>
> WOW, it is working now! Thanks a lot!
>
> alex@tornado:~/bios$ sudo ../development/flashrom/trunk/flashrom
> flashrom v0.9.0-r566
> No coreboot table found.
> Found chipset "NVIDIA CK804", enabling flash write... OK.
> Found board "GIGABYTE GA-K8N-SLI", enabling flash write... OK.
> Calibrating delay loop... OK.
> Found chip "PMC Pm49FL004" (512 KB) at physical address 0xfff80000.
> No operations were specified.
>
> I also tested read, write, erase and verify operations and rebooted the 
> machine with the new bios. Everything is ok!

Great, thanks!

-> r568

Luc Verhaegen.