Re: [LinuxBIOS] r327 - in LinuxBIOSv3: device lib

[Uwe Hermann]

On Sun, May 20, 2007 at 01:55:26AM +0200, [e-mail] wrote:
> /* Print the PCI-X bus speed. */
> printk_debug("PCI: %02x: %s\n", dev->link[0].secondary,
> printk(BIOS_DEBUG, "PCI: %02x: %s\n", dev->link[0].secondary,

This is not related to your modifications, but shouldn't "PCI:" be
"PCI-X:" here?
> Modified: LinuxBIOSv3/lib/stage2.c
>
> --- LinuxBIOSv3/lib/stage2.c	2007-05-19 21:31:23 UTC (rev 326)
> +++ LinuxBIOSv3/lib/stage2.c	2007-05-19 23:55:25 UTC (rev 327)
> @@ -43,7 +43,19 @@
>  {
>    /* TODO: Add comment. */
>    void show_all_devs(void);
> static const char console_test[] =
> "\n\nLinuxBIOS-"
> LINUXBIOS_VERSION
> LINUXBIOS_EXTRA_VERSION
> " "
> LINUXBIOS_BUILD
> " booting...\n";

Is this intentionally printed twice? What you now get is this:

-----------
LinuxBIOS-3.0.0 Sun May 20 17:44:08 CEST 2007 starting...
Choosing normal boot.
LAR: Attempting to open 'normal/initram'.
RAM init code started.
Nothing to do.
Done RAM init code
LAR: Attempting to open 'normal/stage2'.

LinuxBIOS-3.0.0 Sun May 20 17:44:08 CEST 2007 booting...
Phase 1: done
Show all devs...
cpus: Unknown device path type: 0
Phase 2: Early setup...
Phase 2: Done.
-----------

(console_init() already prints the same text)

Uwe.

[LinuxBIOS] r327 - in LinuxBIOSv3: device lib

[Stefan Reinauer]

* Uwe Hermann  [070520 17:50]:
> On Sun, May 20, 2007 at 01:55:26AM +0200, [e-mail] wrote:
> > /* Print the PCI-X bus speed. */
> > printk_debug("PCI: %02x: %s\n", dev->link[0].secondary,
> > printk(BIOS_DEBUG, "PCI: %02x: %s\n", dev->link[0].secondary,
>
> This is not related to your modifications, but shouldn't "PCI:" be
> "PCI-X:" here?

I think so, too..
> Is this intentionally printed twice? What you now get is this:
> LinuxBIOS-3.0.0 Sun May 20 17:44:08 CEST 2007 starting...

[..]
> LinuxBIOS-3.0.0 Sun May 20 17:44:08 CEST 2007 booting...

It is modelled after v2. The pre-ram part prints starting... the
ram-part prints booting.

Not sure whether we really want this twice. I dont care.

Some banner to say "We are in RAM code. You made the most ugly part
work" makes sense though.