Patch merged into coreboot/master: 7f8e685 Load an IDT with NULL limit

the following patch was just integrated into master:
commit 7f8e685996f65f2c67d1113fcfaab33ccc385da7
Author: Stefan Reinauer 
Date:   Wed Jun 1 14:01:46 2011 -0700

Load an IDT with NULL limit

Load an IDT with NULL limit to prevent the 16bit IDT being used
    in protected mode before c_start.S sets up a 32bit IDT when entering
    ram stage.

Signed-off-by: Stefan Reinauer 
    Change-Id: I8d048c894c863ac4971fcef8f065be6b899e1d3e

See http://review.coreboot.org/259 for details.

-gerrit

Gerrit config (was: Re: Patch merged into coreboot/master: 7f8e685 Load an IDT with NULL limit)

[Uwe Hermann]

On Thu, Oct 13, 2011 at 08:04:27PM +0200, [e-mail] wrote:
> the following patch was just integrated into master:
> commit 7f8e685996f65f2c67d1113fcfaab33ccc385da7
> Author: Stefan Reinauer 
> Date:   Wed Jun 1 14:01:46 2011 -0700
> Load an IDT with NULL limit
>
> Load an IDT with NULL limit to prevent the 16bit IDT being used
> in protected mode before c_start.S sets up a 32bit IDT when entering
> ram stage.
>
> Signed-off-by: Stefan Reinauer <[e-mail]>
> Change-Id: I8d048c894c863ac4971fcef8f065be6b899e1d3e
>
> See http://review.coreboot.org/259 for details.

Can gerrit be configured to show

- who approved a patch and when
 - the comment(s) (if any) left by the reviewer?

Having to open the URL in a browser instead of that info being in the
"Patch merged into coreboot/master" mail is really annoying, IMHO.

Uwe.

Gerrit config (was: Re: Patch merged into coreboot/master: 7f8e685 Load an IDT with NULL limit)

[Patrick Georgi]

Am Freitag, den 14.10.2011, 01:32 +0200 schrieb Uwe Hermann:
> On Thu, Oct 13, 2011 at 08:04:27PM +0200, [e-mail] wrote:
> > the following patch was just integrated into master:
> > commit 7f8e685996f65f2c67d1113fcfaab33ccc385da7
> > Author: Stefan Reinauer 
> > Date:   Wed Jun 1 14:01:46 2011 -0700
> > Load an IDT with NULL limit
> >
> > Load an IDT with NULL limit to prevent the 16bit IDT being used
> > in protected mode before c_start.S sets up a 32bit IDT when entering
> > ram stage.
> >
> > Signed-off-by: Stefan Reinauer <[e-mail]>
> > Change-Id: I8d048c894c863ac4971fcef8f065be6b899e1d3e
> >
> > See http://review.coreboot.org/259 for details.
>
> Can gerrit be configured to show
> who approved a patch and when

I implemented this (but didn't add it to the hook yet):
> the comment(s) (if any) left by the reviewer?
>
> Having to open the URL in a browser instead of that info being in the
> "Patch merged into coreboot/master" mail is really annoying, IMHO.
> Uwe.
>
> http://hermann-uwe.de     | http://sigrok.org
> http://randomprojects.org | http://unmaintained-free-software.org

Gerrit config (was: Re: Patch merged into coreboot/master: 7f8e685 Load an IDT with NULL limit)

[Patrick Georgi]

Am Freitag, den 14.10.2011, 01:32 +0200 schrieb Uwe Hermann:
> Can gerrit be configured to show
> who approved a patch and when

I implemented this (but didn't add it to the hook yet):

Reviewed-By: Patrick Georgi  at Fri Oct 14
08:11:24 2011, giving +2
Build-Tested: build bot (Jenkins) at Fri Oct 14 02:56:45 2011, giving +1

Any proposal on how to structure it (I have access to each component:
TYPE NAME [<EMAIL>] at DATETIME, giving VOTE)?
> the comment(s) (if any) left by the reviewer?

Those are harder to fetch, and to represent...

Patrick