[LinuxBIOS] [PATCH] Do not hardcode iasl path.

[Uwe Hermann]

Change the path to iasl from '/usr/sbin/iasl' to 'iasl' in order to not
hardcode it in the config files. The path is different on Debian, for
example (closes #9).

Signed-off-by: Uwe Hermann

---

Can somebody please test (on SUSE?) whether this works as expected, or
whether /usr/sbin needs to be added to PATH somewhere...

Uwe.

[Stefan Reinauer]

* Uwe Hermann  [061031 07:20]:
> Can somebody please test (on SUSE?) whether this works as expected, or
> whether /usr/sbin needs to be added to PATH somewhere...

Yes, indeed SUSE requires /usr/bin to be added to the path.

would it work to do it like this: ?

action  "PATH=$PATH:/usr/sbin iasl -tc $(MAINBOARD)/dx/dsdt_lb.dsl"

(actually it seems to work for me, but is it correct?)

[Peter Stuge]

On Tue, Oct 31, 2006 at 07:55:59AM +0100, Stefan Reinauer wrote:
> Uwe Hermann  [061031 07:20]:
> > Can somebody please test (on SUSE?) whether this works as expected, or
> > whether /usr/sbin needs to be added to PATH somewhere...
>
> Yes, indeed SUSE requires /usr/bin to be added to the path.
>
> would it work to do it like this: ?
>
> action  "PATH=$PATH:/usr/sbin iasl -tc $(MAINBOARD)/dx/dsdt_lb.dsl"
>
> (actually it seems to work for me, but is it correct?)

I'm not sure.

The person running iasl should be the abstraction layer for it's
path. Ideally that person will then complain to their vendor (or
simply switch) when tools are installed in unintuitive places by
default.

On the other hand we should make it as simple as possible to build
LB anywhere.

//Peter

[Stefan Reinauer]

* Peter Stuge  [061031 13:43]:
> > action  "PATH=$PATH:/usr/sbin iasl -tc $(MAINBOARD)/dx/dsdt_lb.dsl"
> >
> > (actually it seems to work for me, but is it correct?)
>
> I'm not sure.
>
> The person running iasl should be the abstraction layer for it's
> path. Ideally that person will then complain to their vendor (or
> simply switch) when tools are installed in unintuitive places by
> default.

You have some point here. Given the large number of systems out there
that "do it wrong", I think we need some kind of "out-of-the-box"
solution here. Its not a big thing anyways. The question is: Can we do
this at some central point, or do we call a wrapper script, or is the
in-place path extension less ugly than those two. :)

Stefan

[Peter Stuge]

On Tue, Oct 31, 2006 at 01:47:08PM +0100, Stefan Reinauer wrote:
> The question is: Can we do this at some central point, or do we
> call a wrapper script, or is the in-place path extension less ugly
> than those two. :)

I say go with PATH then.

//Peter

[Uwe Hermann]

Hi,

On Tue, Oct 31, 2006 at 01:47:08PM +0100, Stefan Reinauer wrote:
> Peter Stuge  [061031 13:43]:
> > > action  "PATH=$PATH:/usr/sbin iasl -tc $(MAINBOARD)/dx/dsdt_lb.dsl"

I think it's safe to assume everyone has /usr/bin in their path. Most
people (but not all, unfortunately) should also have /usr/sbin.

Explicitly setting the PATH is a good idea, nevertheless, but I wouldn't
do it in every "action" line (as above) but rather in a central place
where the tool (the Python thing?) calls iasl.

Other "action" entries don't have an explicit path either, e.g.

action  "perl -pi -e 's/AmlCode/AmlCode_ssdt4/g' pci4.hex"
action  "ar cr linuxbios_apc.a apc_auto.o"
action  "ctags $(SOURCES)"

Uwe.