[PATCH] More explicite and straight way to set seed

[Bao, Zheng]

More explicite and straight way to set seed.

Signed-off-by: Zheng Bao

Index: src/northbridge/amd/amdmct/mct/mctsrc.c
===================================================================
--- src/northbridge/amd/amdmct/mct/mctsrc.c	(revision 6135)
+++ src/northbridge/amd/amdmct/mct/mctsrc.c	(working copy)
@@ -1023,13 +1023,9 @@

dev = pDCTstat->dev_dct;
    for (index = 0x50; index <= 0x52; index ++) {
-		val = Get_NB32_index_wait(dev, index_reg, index);
-		val |= (FenceTrnFinDlySeed & 0x1F);
+		val = (FenceTrnFinDlySeed & 0x1F);
    	if (index != 0x52) {
-			val &= ~(0xFF << 8);
-			val |= (val & 0xFF) << 8;
-			val &= 0xFFFF;
-			val |= val << 16;
+			val |= val << 8 | val << 16 | val << 24;
    	}
    	Set_NB32_index_wait(dev, index_reg, index, val);
    }
Index: src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
===================================================================
--- src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c	(revision 6135)
+++ src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c	(working copy)
@@ -972,13 +972,9 @@
     */
    dev = pDCTstat->dev_dct;
    for (index = 0x50; index <= 0x52; index ++) {
-		val = Get_NB32_index_wait(dev, index_reg, index) &
~0xFF;
-		val |= (FenceTrnFinDlySeed & 0x1F);
+		val = (FenceTrnFinDlySeed & 0x1F);
    	if (index != 0x52) {
-			val &= ~(0xFF << 8);
-			val |= (val & 0xFF) << 8;
-			val &= 0xFFFF;
-			val |= val << 16;
+			val |= val << 8 | val << 16 | val << 24;
    	}
    	Set_NB32_index_wait(dev, index_reg, index, val);
    }

[Marc Jones]

On Tue, Nov 30, 2010 at 10:50 PM, Bao, Zheng  wrote:
> More explicite and straight way to set seed.
>
> Signed-off-by: Zheng Bao
> Index: src/northbridge/amd/amdmct/mct/mctsrc.c
>
> --- src/northbridge/amd/amdmct/mct/mctsrc.c     (revision 6135)
> +++ src/northbridge/amd/amdmct/mct/mctsrc.c     (working copy)
> @@ -1023,13 +1023,9 @@
>
> dev = pDCTstat->dev_dct;
>        for (index = 0x50; index <= 0x52; index ++) {
> val = Get_NB32_index_wait(dev, index_reg, index);
> val |= (FenceTrnFinDlySeed & 0x1F);
> val = (FenceTrnFinDlySeed & 0x1F);
>
> if (index != 0x52) {
> val &= ~(0xFF << 8);
> val |= (val & 0xFF) << 8;
> val &= 0xFFFF;
> val |= val << 16;
> val |= val << 8 | val << 16 | val << 24;
>
> }
>                Set_NB32_index_wait(dev, index_reg, index, val);
>        }
> Index: src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c
> ===================================================================
> --- src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c        (revision 6135)
> +++ src/northbridge/amd/amdmct/mct_ddr3/mctsrc.c        (working copy)
> @@ -972,13 +972,9 @@
>         */
>        dev = pDCTstat->dev_dct;
>        for (index = 0x50; index <= 0x52; index ++) {
> val = Get_NB32_index_wait(dev, index_reg, index) &
>
> ~0xFF;
> val |= (FenceTrnFinDlySeed & 0x1F);
> val = (FenceTrnFinDlySeed & 0x1F);
>
> if (index != 0x52) {
> val &= ~(0xFF << 8);
> val |= (val & 0xFF) << 8;
> val &= 0xFFFF;
> val |= val << 16;
> val |= val << 8 | val << 16 | val << 24;
>
> }
>                Set_NB32_index_wait(dev, index_reg, index, val);
>        }

Yes, the read-modify-write wasn't needed. This easier to understand.

Acked-by: Marc Jones

[Uwe Hermann]

On Wed, Dec 01, 2010 at 10:35:41AM -0700, Marc Jones wrote:
> Acked-by: Marc Jones

Just for archival purposes, this was r6136.

Uwe.