[PATCH] Fix issue with Winbond W83627EHG MIDI driver

[Alex G.]

(See Patch)

This fixes the
"ERROR: device PNP: 002e.207 index 98 has no mask."
that I have been getting on the W83627EHG.

Alex

[Alex G.]

Sorry about forgetting to attach the patch.

Alex

On 02/05/2011 09:50 PM, Alex G. wrote:
> (See Patch)
>
> This fixes the
> "ERROR: device PNP: 002e.207 index 98 has no mask."
> that I have been getting on the W83627EHG.
>
> Alex

[Jonathan A. Kollasch]

On Sat, Feb 05, 2011 at 09:54:49PM +0200, Alex G. wrote:
> Sorry about forgetting to attach the patch.
>
> Alex
>
> On 02/05/2011 09:50 PM, Alex G. wrote:
> > (See Patch)
> >
> > This fixes the
> > "ERROR: device PNP: 002e.207 index 98 has no mask."
> > that I have been getting on the W83627EHG.
> >
> > Alex
> Fixes a problem with the W8327EHG driver, where the midi device
> could get initialised with no mask.
>
> Signed-off-by: Alexandru Gagniuc
> Index: src/superio/winbond/w83627ehg/superio.c
>
> --- src/superio/winbond/w83627ehg/superio.c	(revision 6323)
> +++ src/superio/winbond/w83627ehg/superio.c	(working copy)
> @@ -189,7 +189,7 @@
>    { &ops, W83627EHG_HWM,  PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
>
> { &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
> { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
> { &ops, W83627EHG_MIDI, PNP_IO0 | PNP_IRQ0, {0x07fe, 4}, },
> { &ops, W83627EHG_GPIO1, },
> { &ops, W83627EHG_GPIO2, },
> { &ops, W83627EHG_GPIO3, },

I don't think this is the right fix.
The datasheet says the MIDI BAR is at 62h, 63h.
Hence the mask needs to be in the second position, not the first.

Maybe try something like: 
{ &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, }

Jonathan Kollasch

[Alex G.]

> > Index: src/superio/winbond/w83627ehg/superio.c
> >
> > --- src/superio/winbond/w83627ehg/superio.c	(revision 6323)
> > +++ src/superio/winbond/w83627ehg/superio.c	(working copy)
> > @@ -189,7 +189,7 @@
> >    { &ops, W83627EHG_HWM,  PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
> >
> > { &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
> > { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
> > { &ops, W83627EHG_MIDI, PNP_IO0 | PNP_IRQ0, {0x07fe, 4}, },
> > { &ops, W83627EHG_GPIO1, },
> > { &ops, W83627EHG_GPIO2, },
> > { &ops, W83627EHG_GPIO3, },
>
> I don't think this is the right fix.
> The datasheet says the MIDI BAR is at 62h, 63h.
> Hence the mask needs to be in the second position, not the first.
>
> Maybe try something like: 
> { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, }
>
> Jonathan Kollasch

Thanks. Find attached the updated micropatch.

Alex

[Jonathan A. Kollasch]

On Tue, Feb 08, 2011 at 03:48:44AM +0200, Alex G. wrote:
> > Maybe try something like: 
> > { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, }
> >
> > Jonathan Kollasch
>
> Thanks. Find attached the updated micropatch.
>
> Alex
> Fixes a problem with the W8327EHG driver, where the midi device
> could get initialised with no mask.
>
> Based on input from Jonathan Kollasch
>
> Signed-off-by: Alexandru Gagniuc
> Index: src/superio/winbond/w83627ehg/superio.c
>
> --- src/superio/winbond/w83627ehg/superio.c	(revision 6323)
> +++ src/superio/winbond/w83627ehg/superio.c	(working copy)
> @@ -189,7 +189,7 @@
>    { &ops, W83627EHG_HWM,  PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
>
> { &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
> { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
> { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, },
> { &ops, W83627EHG_GPIO1, },
> { &ops, W83627EHG_GPIO2, },
> { &ops, W83627EHG_GPIO3, },

Acked-by: Jonathan Kollasch

[Jonathan A. Kollasch]

On Tue, Feb 08, 2011 at 02:29:47AM +0000, Jonathan A. Kollasch wrote:
> On Tue, Feb 08, 2011 at 03:48:44AM +0200, Alex G. wrote:
> > > Maybe try something like: 
> > > { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, }
> > >
> > > Jonathan Kollasch
> >
> > Thanks. Find attached the updated micropatch.
> >
> > Alex
> > Fixes a problem with the W8327EHG driver, where the midi device
> > could get initialised with no mask.
> >
> > Based on input from Jonathan Kollasch
> >
> > Signed-off-by: Alexandru Gagniuc
> > Index: src/superio/winbond/w83627ehg/superio.c
> >
> > --- src/superio/winbond/w83627ehg/superio.c	(revision 6323)
> > +++ src/superio/winbond/w83627ehg/superio.c	(working copy)
> > @@ -189,7 +189,7 @@
> >    { &ops, W83627EHG_HWM,  PNP_IO0 | PNP_IRQ0, {0x07fe, 0}, },
> >
> > { &ops, W83627EHG_GAME, PNP_IO0, {0x07ff, 0}, },
> > { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0x07fe, 4}, },
> > { &ops, W83627EHG_MIDI, PNP_IO1 | PNP_IRQ0, {0, 0}, {0x07fe, 4}, },
> > { &ops, W83627EHG_GPIO1, },
> > { &ops, W83627EHG_GPIO2, },
> > { &ops, W83627EHG_GPIO3, },
>
> Acked-by: Jonathan Kollasch

Committed in r6336.