[Patch 2/4] compile sb800 code without agesav5

[She, Kerry]

Hello,

SB800 CIMX code can share the AGESA V5 lib code,

some platform only use sb800 cimx code, not use AGESA v5 code,

compile the sb800 cimx and AGESA v5 lib code.

 

Signed-off-by: Kerry She <[e-mail]>

Regards, 
Kerry She < [e-mail]>
Tel:  [phone] 
Mobile:  86 - 152 1018 2083

[Stefan Reinauer]

* She, Kerry <[e-mail]> [110422 05:12]:
> Signed-off-by: Kerry She <[e-mail]>
>
> SB800 CIMX code can share the AGESA V5 lib code,
> some platform only use sb800 cimx code, not use AGESA v5 code,
> compile the sb800 cimx and AGESA v5 lib code.
>
> Signed-off-by: Kerry She <[e-mail]>
>
> Index: Makefile.inc
> ===================================================================
> --- Makefile.inc        (revision 6481)
> +++ Makefile.inc        (working copy)
> @@ -110,7 +110,9 @@
>  CFLAGS += -Werror
>  endif
>  ifneq ($(CONFIG_AMD_AGESA),y)
> -CFLAGS += -nostdinc
> + ifneq ($(CONFIG_AMD_CIMX_SB800),y)
> +  CFLAGS += -nostdinc
> + endif
>  endif
>  CFLAGS += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer

Why is that needed. Can we instead fix the code, please?

[She, Kerry]

Hello Stefan

The sb800 cimx code originally has its own lib function code,
But these files was removed in the current tree. 
As for now sb800 cimx code share the Agesa v5 lib function code,
but this sharing cause it is not possible to use sb800 cimx wrapper without compile Agesa v5 lib files.

This patch implement the lib function needed by sb800 cimx,
So we can use the sb800 cimx wrapper and Agesa v5 wrapper independently.  

Thanks

--
kerry
> -----Original Message-----
> From: Stefan Reinauer [mailto:[e-mail]]
> Sent: Saturday, April 23, 2011 3:58 AM
> To: She, Kerry
> Cc: [e-mail]
> Subject: Re: [coreboot] [Patch 2/4] compile sb800 code without agesav5
>
> * She, Kerry <[e-mail]> [110422 05:12]:
> > Signed-off-by: Kerry She <[e-mail]>
> >
> > SB800 CIMX code can share the AGESA V5 lib code,
> > some platform only use sb800 cimx code, not use AGESA v5 code,
> > compile the sb800 cimx and AGESA v5 lib code.
> >
> > Signed-off-by: Kerry She <[e-mail]>
> >
> > Index: Makefile.inc
> > ===================================================================
> > --- Makefile.inc        (revision 6481)
> > +++ Makefile.inc        (working copy)
> > @@ -110,7 +110,9 @@
> >  CFLAGS += -Werror
> >  endif
> >  ifneq ($(CONFIG_AMD_AGESA),y)
> > -CFLAGS += -nostdinc
> > + ifneq ($(CONFIG_AMD_CIMX_SB800),y)
> > +  CFLAGS += -nostdinc
> > + endif
> >  endif
> >  CFLAGS += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
>
> Why is that needed. Can we instead fix the code, please?

[Marc Jones]

On Fri, Apr 22, 2011 at 1:58 PM, Stefan Reinauer
<[e-mail]> wrote:
> * She, Kerry <[e-mail]> [110422 05:12]:
> > Signed-off-by: Kerry She <[e-mail]>
> >
> > SB800 CIMX code can share the AGESA V5 lib code,
> > some platform only use sb800 cimx code, not use AGESA v5 code,
> > compile the sb800 cimx and AGESA v5 lib code.
> >
> > Signed-off-by: Kerry She <[e-mail]>
> >
> > Index: Makefile.inc
> > ===================================================================
> > --- Makefile.inc        (revision 6481)
> > +++ Makefile.inc        (working copy)
> > @@ -110,7 +110,9 @@
> >  CFLAGS += -Werror
> >  endif
> >  ifneq ($(CONFIG_AMD_AGESA),y)
> > -CFLAGS += -nostdinc
> > + ifneq ($(CONFIG_AMD_CIMX_SB800),y)
> > +  CFLAGS += -nostdinc
> > + endif
> >  endif
> >  CFLAGS += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer
>
> Why is that needed. Can we instead fix the code, please?

Kerry,

I think that this is fixed with the last patch from Frank. Can you
update this patch and resend.

Marc



-- 
http://se-eng.com

[She, Kerry]

Hello,
> -----Original Message-----
> From: Marc Jones [mailto:[e-mail]]
> Sent: Friday, May 06, 2011 8:52 AM
> To: Stefan Reinauer
> Cc: She, Kerry; [e-mail]
> Subject: Re: [coreboot] [Patch 2/4] compile sb800 code without agesav5
>
> On Fri, Apr 22, 2011 at 1:58 PM, Stefan Reinauer
> <[e-mail]> wrote:
> > * She, Kerry <[e-mail]> [110422 05:12]:
> > > Signed-off-by: Kerry She <[e-mail]>
> > >
> > > SB800 CIMX code can share the AGESA V5 lib code,
> > > some platform only use sb800 cimx code, not use AGESA v5 code,
> > > compile the sb800 cimx and AGESA v5 lib code.
> > >
> > > Signed-off-by: Kerry She <[e-mail]>
> > >
> > > Index: Makefile.inc
> > > ===================================================================
> > > --- Makefile.inc        (revision 6481)
> > > +++ Makefile.inc        (working copy)
> > > @@ -110,7 +110,9 @@
> > >  CFLAGS += -Werror
> > >  endif
> > >  ifneq ($(CONFIG_AMD_AGESA),y)
> > > -CFLAGS += -nostdinc
> > > + ifneq ($(CONFIG_AMD_CIMX_SB800),y)
> > > +  CFLAGS += -nostdinc
> > > + endif
> > >  endif
> > >  CFLAGS += -fno-common -ffreestanding -fno-builtin -fomit-frame-
> > > pointer
> >
> > Why is that needed. Can we instead fix the code, please?
>
> Kerry,
>
> I think that this is fixed with the last patch from Frank. Can you update this patch and resend.

I have update the patch, sb800 code not use stdinc and sse option.
Thanks
--
kerry

[Marc Jones]

On Thu, May 5, 2011 at 8:33 PM, She, Kerry <[e-mail]> wrote:
> Hello,
> > -----Original Message-----
> > From: Marc Jones [mailto:[e-mail]]
> > Sent: Friday, May 06, 2011 8:52 AM
> > To: Stefan Reinauer
> > Cc: She, Kerry; [e-mail]
> > Subject: Re: [coreboot] [Patch 2/4] compile sb800 code without agesav5
> >
> > On Fri, Apr 22, 2011 at 1:58 PM, Stefan Reinauer
> > <[e-mail]> wrote:
> > > * She, Kerry <[e-mail]> [110422 05:12]:
> > > > Signed-off-by: Kerry She <[e-mail]>
> > > >
> > > > SB800 CIMX code can share the AGESA V5 lib code,
> > > > some platform only use sb800 cimx code, not use AGESA v5 code,
> > > > compile the sb800 cimx and AGESA v5 lib code.
> > > >
> > > > Signed-off-by: Kerry She <[e-mail]>
> > > >
> > > > Index: Makefile.inc
> > > > ===================================================================
> > > > --- Makefile.inc        (revision 6481)
> > > > +++ Makefile.inc        (working copy)
> > > > @@ -110,7 +110,9 @@
> > > >  CFLAGS += -Werror
> > > >  endif
> > > >  ifneq ($(CONFIG_AMD_AGESA),y)
> > > > -CFLAGS += -nostdinc
> > > > + ifneq ($(CONFIG_AMD_CIMX_SB800),y)
> > > > +  CFLAGS += -nostdinc
> > > > + endif
> > > >  endif
> > > >  CFLAGS += -fno-common -ffreestanding -fno-builtin -fomit-frame-
> > > > pointer
> > >
> > > Why is that needed. Can we instead fix the code, please?
> >
> > Kerry,
> >
> > I think that this is fixed with the last patch from Frank. Can you update this patch and resend.
>
> I have update the patch, sb800 code not use stdinc and sse option.
> Thanks
> --
> kerry

Acked-by: Marc Jones <[e-mail]>



-- 
http://se-eng.com

[She, Kerry]

> Hello,
> > -----Original Message-----
> > From: Marc Jones [mailto:[e-mail]]
> > Sent: Friday, May 06, 2011 8:52 AM
> > To: Stefan Reinauer
> > Cc: She, Kerry; [e-mail]
> > Subject: Re: [coreboot] [Patch 2/4] compile sb800 code without agesav5
> >
> > On Fri, Apr 22, 2011 at 1:58 PM, Stefan Reinauer
> > <[e-mail]> wrote:
> > > * She, Kerry <[e-mail]> [110422 05:12]:
> > > > Signed-off-by: Kerry She <[e-mail]>
> > > >
> > > > SB800 CIMX code can share the AGESA V5 lib code, some platform only
> > > > use sb800 cimx code, not use AGESA v5 code, compile the sb800 cimx
> > > > and AGESA v5 lib code.
> > > >
> > > > Signed-off-by: Kerry She <[e-mail]>
> > > >
> > > > Index: Makefile.inc
> > > > ===================================================================
> > > > --- Makefile.inc        (revision 6481)
> > > > +++ Makefile.inc        (working copy)
> > > > @@ -110,7 +110,9 @@
> > > >  CFLAGS += -Werror
> > > >  endif
> > > >  ifneq ($(CONFIG_AMD_AGESA),y)
> > > > -CFLAGS += -nostdinc
> > > > + ifneq ($(CONFIG_AMD_CIMX_SB800),y)
> > > > +  CFLAGS += -nostdinc
> > > > + endif
> > > >  endif
> > > >  CFLAGS += -fno-common -ffreestanding -fno-builtin -fomit-frame-
> > > > pointer
> > >
> > > Why is that needed. Can we instead fix the code, please?
> >
> > Kerry,
> >
> > I think that this is fixed with the last patch from Frank. Can you
> > update this patch and resend.
>
> I have update the patch, sb800 code not use stdinc and sse option.
> Thanks
> --
> Kerry
> Another small patch to make sb800 code works without compile agesav5
> thanks

[Marc Jones]

On Thu, May 5, 2011 at 8:43 PM, She, Kerry <[e-mail]> wrote:
> > Hello,
> > > -----Original Message-----
> > > From: Marc Jones [mailto:[e-mail]]
> > > Sent: Friday, May 06, 2011 8:52 AM
> > > To: Stefan Reinauer
> > > Cc: She, Kerry; [e-mail]
> > > Subject: Re: [coreboot] [Patch 2/4] compile sb800 code without agesav5
> > >
> > > On Fri, Apr 22, 2011 at 1:58 PM, Stefan Reinauer
> > > <[e-mail]> wrote:
> > > > * She, Kerry <[e-mail]> [110422 05:12]:
> > > > > Signed-off-by: Kerry She <[e-mail]>
> > > > >
> > > > > SB800 CIMX code can share the AGESA V5 lib code, some platform only
> > > > > use sb800 cimx code, not use AGESA v5 code, compile the sb800 cimx
> > > > > and AGESA v5 lib code.
> > > > >
> > > > > Signed-off-by: Kerry She <[e-mail]>
> > > > >
> > > > > Index: Makefile.inc
> > > > > ===================================================================
> > > > > --- Makefile.inc        (revision 6481)
> > > > > +++ Makefile.inc        (working copy)
> > > > > @@ -110,7 +110,9 @@
> > > > >  CFLAGS += -Werror
> > > > >  endif
> > > > >  ifneq ($(CONFIG_AMD_AGESA),y)
> > > > > -CFLAGS += -nostdinc
> > > > > + ifneq ($(CONFIG_AMD_CIMX_SB800),y)
> > > > > +  CFLAGS += -nostdinc
> > > > > + endif
> > > > >  endif
> > > > >  CFLAGS += -fno-common -ffreestanding -fno-builtin -fomit-frame-
> > > > > pointer
> > > >
> > > > Why is that needed. Can we instead fix the code, please?
> > >
> > > Kerry,
> > >
> > > I think that this is fixed with the last patch from Frank. Can you
> > > update this patch and resend.
> >
> > I have update the patch, sb800 code not use stdinc and sse option.
> > Thanks
> > --
> > Kerry
> > Another small patch to make sb800 code works without compile agesav5
> > thanks

Acked-by: Marc Jones <[e-mail]>

-- 
http://se-eng.com