Re: [coreboot] [v2] r4806 - in trunk/coreboot-v2/src: cpu/amd/model_10xxx cpu/amd/model_fxx cpu/amd/socket_F_1207 mainboard/amd/serengeti_cheetah_fam10 mainboard/kontron/kt690 mainboard/supermicro/x6dhe_g mainboard/supermicro/x6dhe_g2 mainboard/tyan/

[Myles Watson]

On Sun, Oct 18, 2009 at 7:47 AM,  wrote:
> Author: uwe
> Date: 2009-10-18 15:47:30 +0200 (Sun, 18 Oct 2009)
> New Revision: 4806
>
> Modified:
>   trunk/coreboot-v2/src/cpu/amd/model_10xxx/Kconfig
>   trunk/coreboot-v2/src/cpu/amd/model_fxx/Kconfig
>   trunk/coreboot-v2/src/cpu/amd/socket_F_1207/Kconfig
>   trunk/coreboot-v2/src/mainboard/amd/serengeti_cheetah_fam10/Kconfig
>   trunk/coreboot-v2/src/mainboard/kontron/kt690/Kconfig
>   trunk/coreboot-v2/src/mainboard/supermicro/x6dhe_g/Kconfig
>   trunk/coreboot-v2/src/mainboard/supermicro/x6dhe_g2/Kconfig
>   trunk/coreboot-v2/src/mainboard/tyan/s2912_fam10/Kconfig
>   trunk/coreboot-v2/src/northbridge/amd/amdfam10/Kconfig
>   trunk/coreboot-v2/src/northbridge/amd/amdk8/Kconfig
>   trunk/coreboot-v2/src/northbridge/amd/lx/Kconfig
>   trunk/coreboot-v2/src/southbridge/nvidia/ck804/Kconfig
> Log:
> Simplify Kconfig files by using "select" where possible (trivial).

Care needs to be taken that select doesn't break things.  It has no effect
and fails silently when the CONFIG_* isn't defined.
> Signed-off-by: Uwe Hermann 
> Acked-by: Uwe Hermann
> Modified: trunk/coreboot-v2/src/northbridge/amd/amdfam10/Kconfig
>
> --- trunk/coreboot-v2/src/northbridge/amd/amdfam10/Kconfig      2009-10-18
> 13:42:50 UTC (rev 4805)
> +++ trunk/coreboot-v2/src/northbridge/amd/amdfam10/Kconfig      2009-10-18
> 13:47:30 UTC (rev 4806)
> @@ -20,20 +20,12 @@
>  config NORTHBRIDGE_AMD_AMDFAM10
>        bool
>        select HAVE_HIGH_TABLES
>   select HYPERTRANSPORT_PLUGIN_SUPPORT
>   select HT3_SUPPORT
>
> HT3_SUPPORT is no longer defined.  I think this is the right place to put

it since it is the only northbridge that supports HT3.  I guess it could go
in src/devices/Kconfig by HYPERTRANSPORT_PLUGIN_SUPPORT, but the code there
doesn't use it.  Either way it needs to be defined somewhere.

Thanks,
Myles