[WIP] amdfam10: Major ".c" include cleanup

[Damien Zammit]

Hi all,

I am planning to do a cleanup of AMD Fam10-15 codebase,
(i.e., not AGESA).  I have currently completed a first attempt
at removing most of the ".c" includes in romstage.

It currently builds on one board only, KFSN4-DRE, and only works on
DDR2, (DDR3 is WIP).

I would really appreciate someone to take a look at the headers
and comment so I can get a picture of how strict coreboot would like
to be in terms of the header layout.  As in, I don't want to touch
24 boards until I have an idea of how it should be laid out.

Obviously this is going to be a massive cleanup and will need testing on
hardware, I was hoping to use REACTS as a first step once I get things
working.

Any suggestions welcome before I begin to address Kyosti's comments in a
new push.

Damien

[Timothy Pearson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 11/30/2016 10:58 PM, Damien Zammit wrote:
> Hi all,
>
> I am planning to do a cleanup of AMD Fam10-15 codebase,
> (i.e., not AGESA).  I have currently completed a first attempt
> at removing most of the ".c" includes in romstage.
>
> It currently builds on one board only, KFSN4-DRE, and only works on
> DDR2, (DDR3 is WIP).
>
> I would really appreciate someone to take a look at the headers
> and comment so I can get a picture of how strict coreboot would like
> to be in terms of the header layout.  As in, I don't want to touch
> 24 boards until I have an idea of how it should be laid out.

First, thank you very much for tackling this cleanup project!  I'd be
happy to assist where possible.

Have you uploaded your current patchset to Gerrit?  That would probably
be the easiest way for us to comment on your changes.

Thanks!

- -- 
Timothy Pearson
Raptor Engineering
[phone] (direct line)
[phone] (switchboard)
https://www.raptorengineering.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJYQEuVAAoJEK+E3vEXDOFb4zAH/3z66a0Qr8bR7K0FV8Z4tTRX
zNGEHI0gWKFzCpjaZwHc4dGx/b4QicXIgEYulpWHKO9+KiXCRk9U4VwWZEmCFVar
w8PoU07i4f6p3wunHDXzc2Q8EauAzam/6/wq6eSjc9gKgjVU/KzsYSuVpPeSKLD4
HUuYqFOGqJmoVEPf+X0O1apOpzgP4E1LOIGfgukGt8psOXSoDakaLbrYLf3yiI1Q
sbMGFR7l149Hs4tQ37Vr1ITiXXV3ewUoO+awoRtyA/5GCxoDcjYd486o+8D42SSr
kqtXsP5+OrtdJTjtk7c952RkDj8p/JpFuS3k82PXD0cV3Y5Y8OyOc8R1hMV8eRQ=
=nzoX
-----END PGP SIGNATURE-----

[Damien Zammit]

On 02/12/16 03:11, Timothy Pearson wrote:
> Have you uploaded your current patchset to Gerrit?  That would probably
> be the easiest way for us to comment on your changes.

Yes, I forgot to mention my current gerrit link:

https://review.coreboot.org/#/c/17625/

Thanks