This fixes a curses drawing problem - characters are getting accidently sign extended, which is badness for drawing characters (i.e chars with values >= 128). This works around the problem so the right values get sent to VGA. -- Jordan Crouse Systems Software Development Engineer Advanced Micro Devices, Inc.
On Thu, Mar 27, 2008 at 03:34:50PM -0600, Jordan Crouse wrote:
[libpayload] Work around sign-extending issue
somewhere characters are getting sign-extended, meaning that the attributes of the drawing chars ( >= 128) are wrong. Cast the value before sending it to vga.
Signed-off-by: Jordan Crouse <jordan.crouse@amd.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de> Tested in QEMU. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
On Thu, Mar 27, 2008 at 11:12:35PM +0100, Uwe Hermann wrote:
On Thu, Mar 27, 2008 at 03:34:50PM -0600, Jordan Crouse wrote:
[libpayload] Work around sign-extending issue
somewhere characters are getting sign-extended, meaning that the attributes of the drawing chars ( >= 128) are wrong. Cast the value before sending it to vga.
Signed-off-by: Jordan Crouse <jordan.crouse@amd.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
Tested in QEMU.
Also tested on hardware now. Committed in r3195. Uwe. -- http://www.hermann-uwe.de | http://www.holsham-traders.de http://www.crazy-hacks.org | http://www.unmaintained-free-software.org
participants (2)
-
Jordan Crouse -
Uwe Hermann