the following patch was just integrated into master: commit d45a87a4461dc78c19b9c7ab89968abf911e91a7 Author: zbao firstname.lastname@example.org Date: Tue May 29 14:59:38 2012 +0800
Initializer of a static member in union.
It is just me or does anybody have the same build error without this patch? ------ src/arch/x86/boot/acpigen.c: In function 'acpigen_write_empty_PTC': src/arch/x86/boot/acpigen.c:347:3: error: unknown field 'resv' specified in initializer src/arch/x86/boot/acpigen.c:347:3: warning: missing braces around initializer src/arch/x86/boot/acpigen.c:347:3:warning: (near initialization for 'addr.<anonymous>') -------
Anyway, I believe at least this will cause warnings. "resv" is a member of a union, not of acpi_addr_t. So it should be wrapped by a brace in the initializer.
Build-Tested: build bot (Jenkins) at Tue May 29 07:57:18 2012, giving +1 Reviewed-By: Stefan Reinauer email@example.com at Tue May 29 19:45:05 2012, giving +2 Reviewed-By: Marc Jones firstname.lastname@example.org at Wed May 30 23:01:23 2012, giving +2 See http://review.coreboot.org/1056 for details.