Intel Braswell uploads

[Frans Hendriks]

Hi,

I'm working on Intel Braswell implementation and uploaded several patches.

It seems that the maintainer of the Intel Braswell is not active for review/merge/reply of the uploads.
Is the maintainer in MAINTAINERS document correct and still active?

Met vriendelijke groet / Best regards,
Frans Hendriks
Eltan B.V.

[Angel Pons]

Hello,

On Fri, Feb 1, 2019 at 10:53 AM Frans Hendriks  wrote:
> Hi,
>
> I'm working on Intel Braswell implementation and uploaded several patches.
>
> It seems that the maintainer of the Intel Braswell is not active for review/merge/reply of the uploads.
> Is the maintainer in MAINTAINERS document correct and still active?
>
> Met vriendelijke groet / Best regards,
> Frans Hendriks
> Eltan B.V.
> _______________________________________________
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

There are mail addresses on MAINTAINERS. I CC'd this message to the
maintainer for braswell so that they can reply to it.

Best regards,

Angel Pons

[Frans Hendriks]

Hi,

Still no  response from MAINTAINERS.

Is there a way have to trigger review/merge/reply?
Or just keep waiting?

Best regards,
Frans

-----Original Message-----
From: Angel Pons [mailto:[e-mail]] 
Sent: vrijdag 1 februari 2019 11:13
To: Frans Hendriks 
Cc: [e-mail]; [e-mail]
Subject: Re: [coreboot] Intel Braswell uploads

Hello,

On Fri, Feb 1, 2019 at 10:53 AM Frans Hendriks  wrote:
> Hi,
>
> I'm working on Intel Braswell implementation and uploaded several patches.
>
> It seems that the maintainer of the Intel Braswell is not active for review/merge/reply of the uploads.
> Is the maintainer in MAINTAINERS document correct and still active?
>
> Met vriendelijke groet / Best regards,
> Frans Hendriks
> Eltan B.V.
> _______________________________________________
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

There are mail addresses on MAINTAINERS. I CC'd this message to the
maintainer for braswell so that they can reply to it.

Best regards,

Angel Pons

[Lance Zhao]

She's not working at Intel any more, so I don't think there will be
response there.

On Wed, Feb 27, 2019 at 4:00 PM Frans Hendriks  wrote:
> Hi,
>
> Still no  response from MAINTAINERS.
>
> Is there a way have to trigger review/merge/reply?
> Or just keep waiting?
>
> Best regards,
> Frans
>
> -----Original Message-----
> From: Angel Pons [mailto:[e-mail]]
> Sent: vrijdag 1 februari 2019 11:13
> To: Frans Hendriks 
> Cc: [e-mail]; [e-mail]
> Subject: Re: [coreboot] Intel Braswell uploads
>
> Hello,
>
> On Fri, Feb 1, 2019 at 10:53 AM Frans Hendriks 
> wrote:
> > Hi,
> >
> > I'm working on Intel Braswell implementation and uploaded several
>
> patches.
> > It seems that the maintainer of the Intel Braswell is not active for
>
> review/merge/reply of the uploads.
> > Is the maintainer in MAINTAINERS document correct and still active?
> >
> > Met vriendelijke groet / Best regards,
> > Frans Hendriks
> > Eltan B.V.
> > _______________________________________________
> > coreboot mailing list -- [e-mail]
> > To unsubscribe send an email to [e-mail]
>
> There are mail addresses on MAINTAINERS. I CC'd this message to the
> maintainer for braswell so that they can reply to it.
>
> Best regards,
>
> Angel Pons
>
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Michal Zygowski]

Hello,

I am going to push a new Braswell mainboard for review soon too and I
will be in the same situation as Frans. Without his patches, the boards
will not operate as they should.

Maybe we should think of transferring the maintainership of Braswell SoC?

Regarding the review, I have tested the patches on 3 different Braswell
SoCs, so I am going to give +2. IMO it is pointless to wait for response
from maintainers, taking into consideration that they are not working in
Intel anymore.

I would like to submit my candidacy for Braswell SoC maintainership
along with Piotr Król. Since we have 3 Braswell SoC platforms on hand,
we are willing to test any incoming patches to Braswell SoC code base.
We would be glad to become the maintainers. Would like to hear Your
opinions, dear coreboot developers/maintainers, what do You think about
the change?

Best regards,
Michał

On 27.02.2019 10:00, Lance Zhao wrote:
> She's not working at Intel any more, so I don't think there will be
> response there.
>
> On Wed, Feb 27, 2019 at 4:00 PM Frans Hendriks <[e-mail]
> > wrote:
> Hi,
>
> Still no  response from MAINTAINERS.
>
> Is there a way have to trigger review/merge/reply?
> Or just keep waiting?
>
> Best regards,
> Frans
>
> -----Original Message-----
> From: Angel Pons [mailto:[e-mail]
> <mailto:[e-mail]>]
> Sent: vrijdag 1 februari 2019 11:13
> To: Frans Hendriks <[e-mail] <mailto:[e-mail]>>
> Cc: [e-mail] <mailto:[e-mail]>;
> [e-mail] <mailto:[e-mail]>
> Subject: Re: [coreboot] Intel Braswell uploads
>
> Hello,
>
> On Fri, Feb 1, 2019 at 10:53 AM Frans Hendriks
> <[e-mail] <mailto:[e-mail]>> wrote:
> >
> > Hi,
> >
> > I'm working on Intel Braswell implementation and uploaded
> several patches.
> >
> > It seems that the maintainer of the Intel Braswell is not active
> for review/merge/reply of the uploads.
> > Is the maintainer in MAINTAINERS document correct and still active?
> >
> > Met vriendelijke groet / Best regards,
> > Frans Hendriks
> > Eltan B.V.
> > _______________________________________________
> > coreboot mailing list -- [e-mail]
> <mailto:[e-mail]>
> > To unsubscribe send an email to [e-mail]
> <mailto:[e-mail]>
>
> There are mail addresses on MAINTAINERS. I CC'd this message to the
> maintainer for braswell so that they can reply to it.
>
> Best regards,
>
> Angel Pons
>
>
>
>
> _______________________________________________
> coreboot mailing list -- [e-mail]
> <mailto:[e-mail]>
> To unsubscribe send an email to [e-mail]
> <mailto:[e-mail]>
>
>
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Patrick Rudolph]

On Thu, 2019-02-28 at 08:51 +0100, Michal Zygowski wrote:
> I would like to submit my candidacy for Braswell SoC maintainership
> along with Piotr Król. Since we have 3 Braswell SoC platforms on
> hand, we are willing to test any incoming patches to Braswell SoC
> code base. We would be glad to become the maintainers. Would like to
> hear Your opinions, dear coreboot developers/maintainers, what do You
> think about the change?

Hi Michal,
I'm glad to see that you want to maintain an additional platform.

I recommend to email all maintainers, that are not known to be active,
as part of the half year release process. If you don't get a response
or a bounce message the platform should be marked as unmaintained.

What do you think about adding a "supporters section" to the start page
of https://coreboot.org/ to ackknowledge companies that really maintain
coreboot code.

Regards,

[Frans Hendriks]

An additional question related to this SoC and new mainboards:
Should maintainer of Braswell SoC also take care of review/merge new mainboards based on this chipset?

Who should merge new boards? 
(I have uploaded code for two mainboards based on this SoC, where 1 is waiting 3 months to be merged?)

Best regards,
Frans Hendriks
Eltan B.V.

-----Original Message-----
From: Patrick Rudolph [mailto:[e-mail]] 
Sent: donderdag 28 februari 2019 09:20
To: Michal Zygowski ; [e-mail]
Subject: [coreboot] Re: Intel Braswell uploads

On Thu, 2019-02-28 at 08:51 +0100, Michal Zygowski wrote:
> I would like to submit my candidacy for Braswell SoC maintainership 
> along with Piotr Król. Since we have 3 Braswell SoC platforms on hand, 
> we are willing to test any incoming patches to Braswell SoC code base. 
> We would be glad to become the maintainers. Would like to hear Your 
> opinions, dear coreboot developers/maintainers, what do You think 
> about the change?

Hi Michal,
I'm glad to see that you want to maintain an additional platform.

I recommend to email all maintainers, that are not known to be active, as part of the half year release process. If you don't get a response or a bounce message the platform should be marked as unmaintained.

What do you think about adding a "supporters section" to the start page of https://coreboot.org/ to ackknowledge companies that really maintain coreboot code.

Regards,
--
Patrick Rudolph

9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
Email:  [e-mail]
Phone:  [phone]

Sitz der Gesellschaft: Bochum
Handelsregister: Amtsgericht Bochum, HRB 17519
Geschäftsführung: Sebastian Deutsch, Daniel Hoelzgen _______________________________________________
coreboot mailing list -- [e-mail] To unsubscribe send an email to [e-mail]

[Matt DeVillier]

hi Frans,

I'm happy to review these patches (and think I have for some already), but
as my Braswell-based ChromeOS boards don't require them, a little more
explanation in the commit msgs as to what issue they are resolving would be
helpful in that regard.  Obviously I'd like to test them and ensure no
regressions for my boards as well

cheers,
Matt

On Thu, Feb 28, 2019 at 2:42 AM Frans Hendriks  wrote:
> An additional question related to this SoC and new mainboards:
> Should maintainer of Braswell SoC also take care of review/merge new
> mainboards based on this chipset?
>
> Who should merge new boards?
> (I have uploaded code for two mainboards based on this SoC, where 1 is
> waiting 3 months to be merged?)
>
> Best regards,
> Frans Hendriks
> Eltan B.V.
>
> -----Original Message-----
> From: Patrick Rudolph [mailto:[e-mail]]
> Sent: donderdag 28 februari 2019 09:20
> To: Michal Zygowski ; [e-mail]
> Subject: [coreboot] Re: Intel Braswell uploads
>
> On Thu, 2019-02-28 at 08:51 +0100, Michal Zygowski wrote:
> > I would like to submit my candidacy for Braswell SoC maintainership
> > along with Piotr Król. Since we have 3 Braswell SoC platforms on hand,
> > we are willing to test any incoming patches to Braswell SoC code base.
> > We would be glad to become the maintainers. Would like to hear Your
> > opinions, dear coreboot developers/maintainers, what do You think
> > about the change?
>
> Hi Michal,
> I'm glad to see that you want to maintain an additional platform.
>
> I recommend to email all maintainers, that are not known to be active, as
> part of the half year release process. If you don't get a response or a
> bounce message the platform should be marked as unmaintained.
>
> What do you think about adding a "supporters section" to the start page of
> https://coreboot.org/ to ackknowledge companies that really maintain
> coreboot code.
> Regards,
>
> Patrick Rudolph
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
> Email:  [e-mail]
> Phone:  [phone]
>
> Sitz der Gesellschaft: Bochum
> Handelsregister: Amtsgericht Bochum, HRB 17519
> Geschäftsführung: Sebastian Deutsch, Daniel Hoelzgen
> _______________________________________________
> coreboot mailing list -- [e-mail] To unsubscribe send an
> email to [e-mail]
> _______________________________________________
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Michal Zygowski]

On 28.02.2019 09:52, Matt DeVillier wrote:
> hi Frans,
>
> I'm happy to review these patches (and think I have for some already),
> but as my Braswell-based ChromeOS boards don't require them, a little
> more explanation in the commit msgs as to what issue they are
> resolving would be helpful in that regard.  Obviously I'd like to test
> them and ensure no regressions for my boards as well

Hi Matt,

I have added some comments to these patches. As ChromeOS may not require
them (and I am aware of that since I worked once with Chromebook), the
SeaBIOS payload have problems (especially with interrupts and keyboard
input) and other operating systems complain. We are awaiting for Your
review.

I have added short comments on few of these patches. Feel free to ask
questions under the patches, I will hopefully give satisfying answers.
> cheers,
> Matt

Best regards,
Michał
> On Thu, Feb 28, 2019 at 2:42 AM Frans Hendriks <[e-mail]
> > wrote:
> An additional question related to this SoC and new mainboards:
> Should maintainer of Braswell SoC also take care of review/merge
> new mainboards based on this chipset?
>
> Who should merge new boards?
> (I have uploaded code for two mainboards based on this SoC, where
> 1 is waiting 3 months to be merged?)
>
> Best regards,
> Frans Hendriks
> Eltan B.V.
>
> -----Original Message-----
> From: Patrick Rudolph [mailto:[e-mail]
> <mailto:[e-mail]>]
> Sent: donderdag 28 februari 2019 09:20
> To: Michal Zygowski <[e-mail]
> <mailto:[e-mail]>>; [e-mail]
> <mailto:[e-mail]>
> Subject: [coreboot] Re: Intel Braswell uploads
>
> On Thu, 2019-02-28 at 08:51 +0100, Michal Zygowski wrote:
> > I would like to submit my candidacy for Braswell SoC maintainership
> > along with Piotr Król. Since we have 3 Braswell SoC platforms on
> hand,
> > we are willing to test any incoming patches to Braswell SoC code
> base.
> > We would be glad to become the maintainers. Would like to hear Your
> > opinions, dear coreboot developers/maintainers, what do You think
> > about the change?
>
> Hi Michal,
> I'm glad to see that you want to maintain an additional platform.
>
> I recommend to email all maintainers, that are not known to be
> active, as part of the half year release process. If you don't get
> a response or a bounce message the platform should be marked as
> unmaintained.
>
> What do you think about adding a "supporters section" to the start
> page of https://coreboot.org/ to ackknowledge companies that
> really maintain coreboot code.
>
> Regards,
> --
> Patrick Rudolph
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
> Email:  [e-mail]
> <mailto:[e-mail]>
> Phone:  [phone]
>
> Sitz der Gesellschaft: Bochum
> Handelsregister: Amtsgericht Bochum, HRB 17519
> Geschäftsführung: Sebastian Deutsch, Daniel Hoelzgen
> _______________________________________________
> coreboot mailing list -- [e-mail]
> <mailto:[e-mail]> To unsubscribe send an email to
> [e-mail] <mailto:[e-mail]>
> _______________________________________________
> coreboot mailing list -- [e-mail]
> <mailto:[e-mail]>
> To unsubscribe send an email to [e-mail]
> <mailto:[e-mail]>
>
>
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]

[Patrick Rudolph]

On Thu, 2019-02-28 at 08:41 +0000, Frans Hendriks wrote:
> An additional question related to this SoC and new mainboards:
> Should maintainer of Braswell SoC also take care of review/merge new
> mainboards based on this chipset?
>
> Who should merge new boards? 
> (I have uploaded code for two mainboards based on this SoC, where 1
> is waiting 3 months to be merged?)
>
> Best regards,
> Frans Hendriks
> Eltan B.V.

Everybody should review (new mainboards), not only the platform
maintainers.
As boards consists of multiple parts: EC, SuperIO, Audio, Ethernet,
DRAM, GPIOs, ... you can only review the part you are an expert in.

Of course everybody is short on time and as most boards do not have a
good documentation (from firmware developer perspective) or schematics
publicly available, it makes reviewing hard and time consuming.

I don't have a good solution for that, except request reviews in
regular intervals.

Regards,
> -----Original Message-----
> From: Patrick Rudolph [mailto:[e-mail]] 
> Sent: donderdag 28 februari 2019 09:20
> To: Michal Zygowski ; 
> [e-mail]
> Subject: [coreboot] Re: Intel Braswell uploads
>
> On Thu, 2019-02-28 at 08:51 +0100, Michal Zygowski wrote:
> > I would like to submit my candidacy for Braswell SoC
> > maintainership 
> > along with Piotr Król. Since we have 3 Braswell SoC platforms on
> > hand, 
> > we are willing to test any incoming patches to Braswell SoC code
> > base. 
> > We would be glad to become the maintainers. Would like to hear
> > Your 
> > opinions, dear coreboot developers/maintainers, what do You think 
> > about the change?
>
> Hi Michal,
> I'm glad to see that you want to maintain an additional platform.
>
> I recommend to email all maintainers, that are not known to be
> active, as part of the half year release process. If you don't get a
> response or a bounce message the platform should be marked as
> unmaintained.
>
> What do you think about adding a "supporters section" to the start
> page of https://coreboot.org/ to ackknowledge companies that really
> maintain coreboot code.
> Regards,
>
> Patrick Rudolph
>
> 9elements Agency GmbH, Kortumstraße 19-21, 44787 Bochum, Germany
> Email:  [e-mail]
> Phone:  [phone]
>
> Sitz der Gesellschaft: Bochum
> Handelsregister: Amtsgericht Bochum, HRB 17519
> Geschäftsführung: Sebastian Deutsch, Daniel Hoelzgen
> _______________________________________________
> coreboot mailing list -- [e-mail] To unsubscribe send an
> email to [e-mail]

[Michal Zygowski]

On 28.02.2019 09:20, Patrick Rudolph wrote:
> On Thu, 2019-02-28 at 08:51 +0100, Michal Zygowski wrote:
> > I would like to submit my candidacy for Braswell SoC maintainership
> > along with Piotr Król. Since we have 3 Braswell SoC platforms on
> > hand, we are willing to test any incoming patches to Braswell SoC
> > code base. We would be glad to become the maintainers. Would like to
> > hear Your opinions, dear coreboot developers/maintainers, what do You
> > think about the change?
>
> Hi Michal,
> I'm glad to see that you want to maintain an additional platform.

Hi Patrick,
> I recommend to email all maintainers, that are not known to be active,
> as part of the half year release process. If you don't get a response
> or a bounce message the platform should be marked as unmaintained.
>
> What do you think about adding a "supporters section" to the start page
> of https://coreboot.org/ to ackknowledge companies that really maintain
> coreboot code.

Sounds good. Fine for me as a temporary solution.
AFAIK gerrit now adds the reviewers to patches based on MAINTAINERS
file. It would be great to be added automatically to Braswell patches.
Is there a way to workaround that without being Braswell maintainer?
> Regards,

Best regards,
Michał

[Nico Huber]

Hi Michal,

On 28.02.19 10:38, Michal Zygowski wrote:
> AFAIK gerrit now adds the reviewers to patches based on MAINTAINERS
> file. It would be great to be added automatically to Braswell patches.
> Is there a way to workaround that without being Braswell maintainer?

you can just push a patch that adds you to the MAINTAINERS file. I don't
think there is any requirement to be a maintainer, it's just your offer
to look into things. Please also consider removing stale entries and up-
dating the status (e.g. from Supported to Maintained, in case you prefer
that).

You can also set up "Notifications" in Gerrit based on a search pattern.

Nico

[Frans Hendriks]

Hi Michal,

How about adding both of us as MAINTAINERS for the Braswell patches?

Best regards,
Frans Hendriks
Eltan B.V.

-----Original Message-----
From: Nico Huber [mailto:[e-mail]] 
Sent: donderdag 28 februari 2019 10:49
To: Michal Zygowski ; [e-mail]
Subject: [coreboot] Re: Intel Braswell uploads

Hi Michal,

On 28.02.19 10:38, Michal Zygowski wrote:
> AFAIK gerrit now adds the reviewers to patches based on MAINTAINERS
> file. It would be great to be added automatically to Braswell patches.
> Is there a way to workaround that without being Braswell maintainer?

you can just push a patch that adds you to the MAINTAINERS file. I don't
think there is any requirement to be a maintainer, it's just your offer
to look into things. Please also consider removing stale entries and up-
dating the status (e.g. from Supported to Maintained, in case you prefer
that).

You can also set up "Notifications" in Gerrit based on a search pattern.

Nico
_______________________________________________
coreboot mailing list -- [e-mail]
To unsubscribe send an email to [e-mail]

[Michal Zygowski]

On 01.03.2019 11:04, Frans Hendriks wrote:
> Hi Michal,
>
> How about adding both of us as MAINTAINERS for the Braswell patches?

Hi Frans,

Sure, would be glad to cooperate with You. I will submit a patch in a while.
> Best regards,
> Frans Hendriks
> Eltan B.V.

Best regards,
Michał Żygowski
> -----Original Message-----
> From: Nico Huber [mailto:[e-mail]] 
> Sent: donderdag 28 februari 2019 10:49
> To: Michal Zygowski ; [e-mail]
> Subject: [coreboot] Re: Intel Braswell uploads
>
> Hi Michal,
>
> On 28.02.19 10:38, Michal Zygowski wrote:
> > AFAIK gerrit now adds the reviewers to patches based on MAINTAINERS
> > file. It would be great to be added automatically to Braswell patches.
> > Is there a way to workaround that without being Braswell maintainer?
>
> you can just push a patch that adds you to the MAINTAINERS file. I don't
> think there is any requirement to be a maintainer, it's just your offer
> to look into things. Please also consider removing stale entries and up-
> dating the status (e.g. from Supported to Maintained, in case you prefer
> that).
>
> You can also set up "Notifications" in Gerrit based on a search pattern.
>
> Nico
> _______________________________________________
> coreboot mailing list -- [e-mail]
> To unsubscribe send an email to [e-mail]