Re: [coreboot] [coreboot-gerrit] Patch set updated for coreboot: 851c693 intel/minnowmax: Enable S3 suspend/resume

[Marc Jones]

Hi Mohan,

Thanks for the S3 patches. What OSs have you tested S3 with? Have you
tested that all the peripherals are working? I'm debugging a resume
hang on Mint:

[   66.091759] PM: resume of devices complete after 1237.808 msecs
[   66.675574] PM: Finishing wakeup.
[   66.679321] Restarting tasks ...
[   66.683058] BUG: unable to handle kernel paging request at ffffffff4b86d1d8
[   66.698356] IP: [<ffffffff81098adc>] cpus_share_cache+0xc/0x40
[   66.708645] PGD 1c11067 PUD 0
[   66.715812] Oops: 0000 [#2] SMP
[   66.723179] Modules linked in: coretemp kvm_intel kvm
crct10dif_pclmul crc32_pi
[   66.774920] CPU: 1 PID: 2067 Comm: pm-suspend Tainted: G      D
 3.13.0-24u
[   66.789363] Hardware name: Intel Minnow Max 2GB/Minnow Max 2GB,
BIOS 4.0 10/074
[   66.802465] task: ffff880064072fe0 ti: ffff88005efe6000 task.ti:
ffff88005efe60
[   66.815416] RIP: 0010:[<ffffffff81098adc>]  [<ffffffff81098adc>]
cpus_share_ca0
[   66.829327] RSP: 0000:ffff88005efe7ce0  EFLAGS: 00010017
[   66.839943] RAX: 0000000000000000 RBX: 00000000f936b707 RCX: ffff880077c35fc0
[   66.852661] RDX: ffff88007b714440 RSI: 0000000000000001 RDI: fffffffff936b707
[   66.865387] RBP: ffff88005efe7d88 R08: 0000000000000010 R09: 00000000ffffffff
[   66.878133] R10: 0000000000000000 R11: 00000000000003f9 R12: 0000000000000001
[   66.890902] R13: 0000000000014440 R14: 0000000000000001 R15: 00000000f936b707
[   66.903678] FS:  00007f40204b7740(0000) GS:ffff88007b700000(0000)
knlGS:0000000
[   66.917524] CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
[   66.928724] CR2: ffffffff4b86d1d8 CR3: 000000005081c000 CR4: 00000000001007e0
[   66.941523] Stack:
[   66.948602]  ffff88005efe7d88 ffffffff8109fa92 000000005efe7d18
00000000005b8d0
[   66.961788]  ffff88007b714440 ffff880074432fe0 ffff880000000010
000000000000000
[   66.974951]  0000000000000001 ffff88005efe7d40 ffffffff00000001
ffff880074432f0
[   66.988138] Call Trace:
[   66.995783]  [<ffffffff8109fa92>] ? select_task_rq_fair+0x582/0x6f0
[   67.007754]  [<ffffffff81097fe9>] ? ttwu_do_wakeup+0x19/0xc0
[   67.019002]  [<ffffffff8109a5b1>] try_to_wake_up+0x141/0x2c0
[   67.030212]  [<ffffffff8109a753>] wake_up_process+0x23/0x40
[   67.041269]  [<ffffffff810cb85c>] __thaw_task+0x2c/0x40
[   67.051900]  [<ffffffff810b3960>] thaw_processes+0xa0/0x130
[   67.062938]  [<ffffffff810b435e>] pm_suspend+0x18e/0x260
[   67.073698]  [<ffffffff810b3249>] state_store+0x79/0xf0
[   67.084369]  [<ffffffff8135f24f>] kobj_attr_store+0xf/0x20
[   67.095326]  [<ffffffff8122f418>] sysfs_write_file+0x128/0x1c0
[   67.106672]  [<ffffffff811b9534>] vfs_write+0xb4/0x1f0
[   67.117246]  [<ffffffff811b9f69>] SyS_write+0x49/0xa0
[   67.127682]  [<ffffffff817266bf>] tracesys+0xe1/0xe6
[   67.137998] Code: e0 ff ff a8 08 0f 84 8d fe ff ff e9 3a ff ff ff
66 66 66 66
[   67.164624] RIP  [<ffffffff81098adc>] cpus_share_cache+0xc/0x40
[   67.176349]  RSP <ffff88005efe7ce0>
[   67.185315] CR2: ffffffff4b86d1d8
[   67.194031] ---[ end trace 7f6401edfae25206 ]---
[   96.598277] ------------[ cut here ]------------
[   96.603441] WARNING: CPU: 1 PID: 36 at
/build/buildd/linux-3.13.0/kernel/watch)
[   96.616163] Watchdog detected hard LOCKUP on cpu 1
[   96.621308] Modules linked in: coretemp kvm_intel kvm
crct10dif_pclmul crc32_pi
[   96.664488] CPU: 1 PID: 36 Comm: kswapd0 Tainted: G      D
3.13.0-24-geneu
[   96.673916] Hardware name: Intel Minnow Max 2GB/Minnow Max 2GB,
BIOS 4.0 10/074
[   96.682469]  0000000000000009 ffff88007b706c20 ffffffff81715ac4
ffff88007b706c8
[   96.690752]  ffff88007b706c58 ffffffff810676bd ffff880075a25800
000000000000000
[   96.699037]  ffff88007b706d88 0000000000000000 ffff88007b706ef8
ffff88007b706c8
[   96.707320] Call Trace:
[   96.710047]  <NMI>  [<ffffffff81715ac4>] dump_stack+0x45/0x56
[   96.716483]  [<ffffffff810676bd>] warn_slowpath_common+0x7d/0xa0
[   96.723196]  [<ffffffff8106772c>] warn_slowpath_fmt+0x4c/0x50
[   96.729618]  [<ffffffff8110d330>] ? restart_watchdog_hrtimer+0x50/0x50
[   96.736914]  [<ffffffff8110d3cc>] watchdog_overflow_callback+0x9c/0xd0
[   96.744209]  [<ffffffff81144b3e>] __perf_event_overflow+0x8e/0x240
[   96.751117]  [<ffffffff81028e48>] ? x86_perf_event_set_period+0xe8/0x150
[   96.758606]  [<ffffffff81145654>] perf_event_overflow+0x14/0x20
[   96.765222]  [<ffffffff8103028d>] intel_pmu_handle_irq+0x1cd/0x3d0
[   96.772132]  [<ffffffff8171f96b>] perf_event_nmi_handler+0x2b/0x50
[   96.779039]  [<ffffffff8171f188>] nmi_handle.isra.3+0x88/0x180
[   96.785559]  [<ffffffff8171f350>] do_nmi+0xd0/0x340
[   96.791009]  [<ffffffff8171e5f1>] end_repeat_nmi+0x1e/0x2e
[   96.797140]  [<ffffffff8171db4f>] ? _raw_spin_lock_irq+0x3f/0x60
[   96.803851]  [<ffffffff8171db4f>] ? _raw_spin_lock_irq+0x3f/0x60
[   96.810563]  [<ffffffff8171db4f>] ? _raw_spin_lock_irq+0x3f/0x60
[   96.817271]  <<EOE>>  [<ffffffff810cb57e>] __refrigerator+0x7e/0x1a0
[   96.824385]  [<ffffffff81163eaa>] kswapd+0x39a/0x410
[   96.829934]  [<ffffffff810aae90>] ? prepare_to_wait_event+0x100/0x100
[   96.837133]  [<ffffffff81163b10>] ? balance_pgdat+0x610/0x610
[   96.843555]  [<ffffffff8108b312>] kthread+0xd2/0xf0
[   96.849005]  [<ffffffff8108b240>] ? kthread_create_on_node+0x1d0/0x1d0
[   96.856300]  [<ffffffff817263fc>] ret_from_fork+0x7c/0xb0
[   96.862333]  [<ffffffff8108b240>] ? kthread_create_on_node+0x1d0/0x1d0
[   96.869626] ---[ end trace 7f6401edfae25207 ]---


On Sat, Sep 27, 2014 at 8:27 AM, Mohan D'Costa <[e-mail]> wrote:
> Mohan D'Costa ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/6972
>
> -gerrit
>
> commit 851c6936af062badc746abb4cc7fe8468c9c5745
> Author: Mohan D'Costa <[e-mail]>
> Date:   Thu Sep 25 18:17:08 2014 +0900
>
> intel/minnowmax: Enable S3 suspend/resume
>
> This enables S3 Suspend / Resume support for MinnowMax board
>     using Intel's Bay Trail FSP
>
> Tested resume from Power Button and Magic Packet.
>
> Change-Id: I021122a68c05f2e725cabb8f3946249afe802bbe
>     Signed-off-by: Mohan D'Costa <[e-mail]>
> ---
>  src/mainboard/intel/minnowmax/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/mainboard/intel/minnowmax/Kconfig b/src/mainboard/intel/minnowmax/Kconfig
> index 0e83d5a..229172c 100644
> --- a/src/mainboard/intel/minnowmax/Kconfig
> +++ b/src/mainboard/intel/minnowmax/Kconfig
> @@ -27,6 +27,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy
>         select HAVE_OPTION_TABLE
>         select OVERRIDE_MRC_CACHE_LOC
>         select TSC_MONOTONIC_TIMER
> +       select HAVE_ACPI_RESUME
>
> config MAINBOARD_DIR
>         string