See patch.
Uwe.
Uwe Hermann wrote:
Only show the USB Debug Port kconfig option to the user if a mainboard is selected that uses a chipset which actually has that functionality _and_ we have code to initialize the Debug Port in coreboot (for that chipset).
Also, remove duplicate list of PCI IDs and just link to the wiki page at:
http://www.coreboot.org/EHCI_Debug_Port
The list is now less useful in the kconfig help as this option will only appear for those boards where it's actually supported.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Maybe mention the Net20DC in the help text too.
Acked-by: Peter Stuge peter@stuge.se
On Sun, Sep 26, 2010 at 06:20:52AM +0200, Peter Stuge wrote:
Uwe Hermann wrote:
Only show the USB Debug Port kconfig option to the user if a mainboard is selected that uses a chipset which actually has that functionality _and_ we have code to initialize the Debug Port in coreboot (for that chipset).
Also, remove duplicate list of PCI IDs and just link to the wiki page at:
http://www.coreboot.org/EHCI_Debug_Port
The list is now less useful in the kconfig help as this option will only appear for those boards where it's actually supported.
Signed-off-by: Uwe Hermann uwe@hermann-uwe.de
Maybe mention the Net20DC in the help text too.
Acked-by: Peter Stuge peter@stuge.se
Thanks, r5848. I mentioned all Debug devices I know about briefly in the help text. We should add more info about the non-NET20DC ones to the wiki though.
Uwe.
On 9/26/10 2:05 AM, Uwe Hermann wrote:
Only show the USB Debug Port kconfig option to the user if a mainboard is selected that uses a chipset which actually has that functionality _and_ we have code to initialize the Debug Port in coreboot (for that chipset).
So using a plugin pci card with that functionality is not possible?
Stefan
Stefan Reinauer wrote:
Only show the USB Debug Port kconfig option to the user if a mainboard is selected that uses a chipset which actually has that functionality _and_ we have code to initialize the Debug Port
So using a plugin pci card with that functionality is not possible?
Good point, no, that will not work, but it never did, because the coreboot build would only have the code support for the onboard southbridge.
If we want to support Debug Port on plugin cards then we need to decouple the code from the southbridges, so that all or none Debug Port support can be selected in Kconfig. Maybe it goes into drivers/ instead then..
//Peter
-
Peter Stuge -
Stefan Reinauer -
Uwe Hermann