New Defects reported by Coverity Scan for coreboot

Hi,

Please find the latest report on new defect(s) introduced to coreboot found with Coverity
Scan.

3 new defect(s) introduced to coreboot found with Coverity Scan.
10 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build
analyzed by Coverity Scan.

New defect(s) Reported-by: Coverity Scan
Showing 3 of 3 defect(s)


** CID 1271711:    (DEADCODE)
/src/include/device/hypertransport_def.h: 25 in offset_unit_id()
/src/include/device/hypertransport_def.h: 25 in offset_unit_id()


________________________________________________________________________________________________________
*** CID 1271711:    (DEADCODE)
/src/include/device/hypertransport_def.h: 25 in offset_unit_id()
19     #define HT_FREQ_VENDOR  15  /* AMD defines this to be 100Mhz */
20     
21     
22     static inline bool offset_unit_id(bool is_sb_ht_chain)
23     {
24     	bool need_offset = (CONFIG_HT_CHAIN_UNITID_BASE != 1) ||
(CONFIG_HT_CHAIN_END_UNITID_BASE != 0x20);
 >>     CID 1271711:    (DEADCODE)
>>     Execution cannot reach the expression "0" inside this statement:
"return need_offset && (0 ||...".
25     	return need_offset
&& (!CONFIG_SB_HT_CHAIN_UNITID_OFFSET_ONLY || is_sb_ht_chain);
26     }
27     
/src/include/device/hypertransport_def.h: 25 in offset_unit_id()
19     #define HT_FREQ_VENDOR  15  /* AMD defines this to be 100Mhz */
20     
21     
22     static inline bool offset_unit_id(bool is_sb_ht_chain)
23     {
24     	bool need_offset = (CONFIG_HT_CHAIN_UNITID_BASE != 1) ||
(CONFIG_HT_CHAIN_END_UNITID_BASE != 0x20);
 >>     CID 1271711:    (DEADCODE)
>>     Execution cannot reach the expression "1" inside this statement:
"return need_offset && (1 ||...".
25     	return need_offset
&& (!CONFIG_SB_HT_CHAIN_UNITID_OFFSET_ONLY || is_sb_ht_chain);
26     }
27     


________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/1016?tab=overview

To manage Coverity Scan email notifications for "coreboot(a)coreboot.org", click
https://scan.coverity.com/subscriptions/edit?email=coreboot%40coreboot.or...
.