Re: [coreboot] [coreboot-gerrit] New patch to review for coreboot: 7d39656 lenovo/x60/romstage.c: Collect timestamps in romstage

[ron minnich]

Again, can we cut this down a bit? Most of what you're saying is
obvious or gratuitous. It's very kind of you to thank people but we
really don't need thanks in the message.

On Tue, Jul 2, 2013 at 1:40 AM, Paul Menzel  wrote:
> Paul Menzel ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3587
>
> -gerrit
>
> commit 7d396566be210dfd5f86c8d9038ae0fdacefa02f
> Author: Paul Menzel 
> Date:   Tue Jul 2 09:54:17 2013 +0200
> lenovo/x60/romstage.c: Collect timestamps in romstage
>
> Collect early timestamps in Lenovo X60’s romstage.

This is fine.
> like the Lenovo T60
>     does. Selecting the option `COLLECT_TIMESTAMPS` in Kconfig and then
>     doing `cbmem --timestamps` should output the timestamps.

Are we going to list *all* the systems that do it? Why? Are we going
to tell people
how to use each Kconfig? Documentation of this type does not belong in
a commit message.
> Thanks to Nico Huber’s work setting this up for the ICH7 and implementing
> it for the T60, all what was needed to do, was to do the equivalent
> changes for the X60 as for the T60 in commit 44c392f8 [1].
>
>     lenovo/t60: Collect timestamps in romstage
>
> [1] http://review.coreboot.org/3499

remove all this text. It's not needed. We all depend on the work of
others. We don't need to cite it in each and every CL.