答复: Disable USB2 in AMD8111 and remove ide hardcode io addr

[YhLu]

According to AMD, USB 2 in amd8111 will never work.

YH

-----邮件原件-----
发件人: ron minnich [mailto:[e-mail]] 
发送时间: 2004年5月5日 7:07
收件人: YhLu
抄送: Stefan Reinauer; [e-mail]
主题: Re: Disable USB2 in AMD8111 and remove ide hardcode io addr

On Wed, 5 May 2004, ron minnich wrote:
> On Tue, 4 May 2004, YhLu wrote:
> > I'm going to add several lines in amd8111_enable of amd8111.c to disable
> > USB2 in amd8111.
> >
> > /* disable usb2 in amd 8111 because it does not work awlays*/
> >         byte = pci_read_config8(lpc_dev, 0x47);
> >         byte |= (1<<7);
> >         pci_write_config8(lpc_dev, 0x47, byte);
>
> this is the wrong way to do this, please don't do it just yet.

ok, the other two changes look fine. 

This disabling is fine if the kernel can later re-enable, but I doubt the 
kernel will do that. We need a way to make this usb enable/disable visible 
at configuration time, so people can turn on/off as needed, unless usb2.0 
on the 8111 NEVER work. I am willing to guess it will work someday, and 
this built-in disable will come back to bite us.

ron

[ron minnich]

On Wed, 5 May 2004, YhLu wrote:
> According to AMD, USB 2 in amd8111 will never work.

well, that's certainly interesting. 

If AMD is certain about that, and no one else objects, I remove any 
concerns I have about this code. But please put in a more informative 
comment such as "will never work"

thanks

ron

答复: Disable USB2 in AMD8111 and remove ide hardcode io addr

YhLu <[e-mail]> writes:
> According to AMD, USB 2 in amd8111 will never work.

As I have read the documentation it says USB 2.0 devices will never
work.  

However what you are disabling is not support for USB 2.0 devices but
a newer USB controller.  Granted it is usually used for USB 2.0
traffic but that is an orthogonal issue.

Eric