[LinuxBIOS] [PATCH] flashrom: Support for ICH7-DH southbridge

[Uwe Hermann]

Not sure if this (alone) helps with Anton's flashrom problem, but it's a
good idea anyway, I guess.

Untested by me, I don't have such a board.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

[Stefan Reinauer]

* Uwe Hermann <[e-mail]> [070331 15:05]:
> Not sure if this (alone) helps with Anton's flashrom problem, but it's a
> good idea anyway, I guess.

No, it wont. His flash chip is SPI. 

Let's wait with this until someone provides a complete patch including 
SPI support. Otherwise people start believing that their ICH7-DH is
supported.
> Add support for the ICH7-DH southbridge (untested, though).
>
> Signed-off-by: Uwe Hermann <[e-mail]>
>
> Index: util/flashrom/flash_enable.c
> ===================================================================
> --- util/flashrom/flash_enable.c	(Revision 2573)
> +++ util/flashrom/flash_enable.c	(Arbeitskopie)
> @@ -436,6 +436,7 @@
>   {0x8086, 0x24d0, "ICH5/ICH5R", enable_flash_ich_4e},
>   {0x8086, 0x2640, "ICH6/ICH6R", enable_flash_ich_dc},
>   {0x8086, 0x2641, "ICH6-M", enable_flash_ich_dc},
> +	{0x8086, 0x27b0, "ICH7DH", enable_flash_ich_dc},
>   {0x8086, 0x27b8, "ICH7/ICH7R", enable_flash_ich_dc},
>   {0x8086, 0x27b9, "ICH7M", enable_flash_ich_dc},
>   {0x8086, 0x27bd, "ICH7MDH", enable_flash_ich_dc},
>

[Uwe Hermann]

On Sat, Mar 31, 2007 at 08:15:35PM +0200, Stefan Reinauer wrote:
> * Uwe Hermann <[e-mail]> [070331 15:05]:
> > Not sure if this (alone) helps with Anton's flashrom problem, but it's a
> > good idea anyway, I guess.
>
> No, it wont. His flash chip is SPI.

Yes, but is this the case for all chips on any ICH7DH-based board?
If not, I think we can commit.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org

[Peter Stuge]

On Sat, Mar 31, 2007 at 08:55:08PM +0200, Uwe Hermann wrote:
> On Sat, Mar 31, 2007 at 08:15:35PM +0200, Stefan Reinauer wrote:
> > * Uwe Hermann <[e-mail]> [070331 15:05]:
> > > Not sure if this (alone) helps with Anton's flashrom problem, but it's a
> > > good idea anyway, I guess.
> >
> > No, it wont. His flash chip is SPI.
>
> Yes, but is this the case for all chips on any ICH7DH-based board?

Not at all. All ICH7 and ICH7-M can do both LPC and SPI. What is used
depends on the individual board.
> If not, I think we can commit.

Me too.

Acked-by: Peter Stuge <[e-mail]>


//Peter

[Uwe Hermann]

On Sat, Mar 31, 2007 at 09:37:10PM +0200, Peter Stuge wrote:
> > Yes, but is this the case for all chips on any ICH7DH-based board?
>
> Not at all. All ICH7 and ICH7-M can do both LPC and SPI. What is used
> depends on the individual board.
> > If not, I think we can commit.
>
> Me too.
>
> Acked-by: Peter Stuge <[e-mail]>

OK, then. Committed in r2575.


Uwe.
-- 
http://www.hermann-uwe.de  | http://www.holsham-traders.de
http://www.crazy-hacks.org | http://www.unmaintained-free-software.org