Well it looks like YABEL debug is broken again.....
util/x86emu/yabel/vbe.c:600: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:604: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:607: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:607: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:612: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:615: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:618: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:621: error: 'vbe_mode_info_t' has no member named 'x_resolution' util/x86emu/yabel/vbe.c:621: error: 'vbe_mode_info_t' has no member named 'y_resolution' util/x86emu/yabel/vbe.c:624: error: 'vbe_mode_info_t' has no member named 'x_charsize' util/x86emu/yabel/vbe.c:624: error: 'vbe_mode_info_t' has no member named 'y_charsize' util/x86emu/yabel/vbe.c:626: error: 'vbe_mode_info_t' has no member named 'bits_per_pixel' util/x86emu/yabel/vbe.c:628: error: 'vbe_mode_info_t' has no member named 'memory_model' util/x86emu/yabel/vbe.c:630: error: 'vbe_mode_info_t' has no member named 'framebuffer_address' util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'x_resolution' util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'y_resolution' util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'bits_per_pixel' util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'framebuffer_address' make: *** [util/x86emu/yabel/vbe.o] Error 1
last part of buildlog attached. Any ideas?
On Tue, 02 Mar 2010 17:23:00 -0500, Joseph Smith joe@settoplinux.org wrote:
Well it looks like YABEL debug is broken again.....
util/x86emu/yabel/vbe.c:600: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:604: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:607: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:607: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:612: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:615: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:618: error: 'vbe_mode_info_t' has no member named 'attributes' util/x86emu/yabel/vbe.c:621: error: 'vbe_mode_info_t' has no member named 'x_resolution' util/x86emu/yabel/vbe.c:621: error: 'vbe_mode_info_t' has no member named 'y_resolution' util/x86emu/yabel/vbe.c:624: error: 'vbe_mode_info_t' has no member named 'x_charsize' util/x86emu/yabel/vbe.c:624: error: 'vbe_mode_info_t' has no member named 'y_charsize' util/x86emu/yabel/vbe.c:626: error: 'vbe_mode_info_t' has no member named 'bits_per_pixel' util/x86emu/yabel/vbe.c:628: error: 'vbe_mode_info_t' has no member named 'memory_model' util/x86emu/yabel/vbe.c:630: error: 'vbe_mode_info_t' has no member named 'framebuffer_address' util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'x_resolution' util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'y_resolution' util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'bits_per_pixel' util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'framebuffer_address' make: *** [util/x86emu/yabel/vbe.o] Error 1
Appears to be something wrong with the union in structure vbe_mode_info_t in vbe.c. It points to another structure vesa_mode_info_t, but I am not sure why it is not working?????
util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'framebuffer_address' make: *** [util/x86emu/yabel/vbe.o] Error 1
Appears to be something wrong with the union in structure vbe_mode_info_t in vbe.c. It points to another structure vesa_mode_info_t, but I am not sure why it is not working?????
It compiles for me with 5132, but not 5135. You could look at the changes: http://tracker.coreboot.org/trac/coreboot/changeset/5135
Thanks, Myles
On Tue, 2 Mar 2010 16:14:17 -0700, Myles Watson mylesgw@gmail.com wrote:
util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'framebuffer_address' make: *** [util/x86emu/yabel/vbe.o] Error 1
Appears to be something wrong with the union in structure
vbe_mode_info_t
in vbe.c. It points to another structure vesa_mode_info_t, but I am not sure why it is not working?????
It compiles for me with 5132, but not 5135. You could look at the
changes:
Yes it appears that union inside of the vbe_mode_info_t structure is new. Is it even ok to put a union inside of a structure?
On Tue, 2 Mar 2010 16:14:17 -0700, Myles Watson mylesgw@gmail.com wrote:
util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'framebuffer_address' make: *** [util/x86emu/yabel/vbe.o] Error 1
Appears to be something wrong with the union in structure
vbe_mode_info_t
in vbe.c. It points to another structure vesa_mode_info_t, but I am not sure why it is not working?????
It compiles for me with 5132, but not 5135. You could look at the
changes:
Yes it appears that union inside of the vbe_mode_info_t structure is new. Is it even ok to put a union inside of a structure?
Yes. It compiles without debug, right?
If I were you I'd comment out the debugging statements that are breaking for you, unless you are trying to debug the vbe code. It looks like framebuffer_address and friends were commented out in 5135.
Thanks, Myles
On Wed, 3 Mar 2010 06:51:34 -0700, "Myles Watson" mylesgw@gmail.com wrote:
On Tue, 2 Mar 2010 16:14:17 -0700, Myles Watson mylesgw@gmail.com
wrote:
util/x86emu/yabel/vbe.c:647: error: 'vbe_mode_info_t' has no member named 'framebuffer_address' make: *** [util/x86emu/yabel/vbe.o] Error 1
Appears to be something wrong with the union in structure
vbe_mode_info_t
in vbe.c. It points to another structure vesa_mode_info_t, but I am
not
sure why it is not working?????
It compiles for me with 5132, but not 5135. You could look at the
changes:
Yes it appears that union inside of the vbe_mode_info_t structure is
new.
Is it even ok to put a union inside of a structure?
Yes. It compiles without debug, right?
Yes.
If I were you I'd comment out the debugging statements that are breaking for you, unless you are trying to debug the vbe code. It looks like framebuffer_address and friends were commented out in 5135.
Well I was kind of looking forward to the vbe debug. Hmm.
It compiles for me with 5132, but not 5135. You could look at the
changes:
Yes. It compiles without debug, right?
Yes.
If I were you I'd comment out the debugging statements that are breaking for you, unless you are trying to debug the vbe code. It looks like framebuffer_address and friends were commented out in 5135.
Well I was kind of looking forward to the vbe debug. Hmm.
You'd still get some information from the debugging statements that work, but the statements referencing undefined variables are not likely to give you any good information.
Patrick and Stefan: Any hints for Joe?
Thanks, Myles
Hi,
i am trying to get a setup to fix this... but i cant even compile... in menuconfig for qemu i cant seem to set CONFIG_DEBUG and thus enabling YABEL_DEBUG breaks the build. If i manually set CONFIG_DEBUG=y in .config and then run make oldconfig, CONFIG_DEBUG is unset again.
Help?
Regards, Pattrick
On Wed, Mar 3, 2010 at 4:05 PM, Myles Watson mylesgw@gmail.com wrote:
It compiles for me with 5132, but not 5135. You could look at the
changes:
Yes. It compiles without debug, right?
Yes.
If I were you I'd comment out the debugging statements that are breaking for you, unless you are trying to debug the vbe code. It looks like framebuffer_address and friends were commented out in 5135.
Well I was kind of looking forward to the vbe debug. Hmm.
You'd still get some information from the debugging statements that work, but the statements referencing undefined variables are not likely to give you any good information.
Patrick and Stefan: Any hints for Joe?
Thanks, Myles
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On 3/5/10 10:42 AM, Pattrick Hueper wrote:
Hi,
i am trying to get a setup to fix this... but i cant even compile... in menuconfig for qemu i cant seem to set CONFIG_DEBUG and thus enabling YABEL_DEBUG breaks the build. If i manually set CONFIG_DEBUG=y in .config and then run make oldconfig, CONFIG_DEBUG is unset again.
Help?
Regards, Pattrick
Do svn up, r5185 should fix X86EMU/YABEL debugging and makes it separately user selectable in "make menuconfig" under the "Debugging" menu.
Stefan
Ah... very cool...
so Josephs issue with VBE debugging is resolved as well?
Patty
On Fri, Mar 5, 2010 at 11:05 AM, Stefan Reinauer stepan@coresystems.de wrote:
On 3/5/10 10:42 AM, Pattrick Hueper wrote:
Hi,
i am trying to get a setup to fix this... but i cant even compile... in menuconfig for qemu i cant seem to set CONFIG_DEBUG and thus enabling YABEL_DEBUG breaks the build. If i manually set CONFIG_DEBUG=y in .config and then run make oldconfig, CONFIG_DEBUG is unset again.
Help?
Regards, Pattrick
Do svn up, r5185 should fix X86EMU/YABEL debugging and makes it separately user selectable in "make menuconfig" under the "Debugging" menu.
Stefan
-- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
On 3/5/10 11:20 AM, Pattrick Hueper wrote:
Ah... very cool...
so Josephs issue with VBE debugging is resolved as well?
Patty
Worked for me... The X86EMU_DEBUG code may want some more tweaking to make it more silent / verbose with some of the flags, though
On 03/05/2010 04:42 AM, Pattrick Hueper wrote:
Hi,
i am trying to get a setup to fix this... but i cant even compile... in menuconfig for qemu i cant seem to set CONFIG_DEBUG and thus enabling YABEL_DEBUG breaks the build. If i manually set CONFIG_DEBUG=y in .config and then run make oldconfig, CONFIG_DEBUG is unset again.
Help?
Regards, Pattrick
On Wed, Mar 3, 2010 at 4:05 PM, Myles Watsonmylesgw@gmail.com wrote:
It compiles for me with 5132, but not 5135. You could look at the
changes:
Yes. It compiles without debug, right?
Yes.
If I were you I'd comment out the debugging statements that are breaking for you, unless you are trying to debug the vbe code. It looks like framebuffer_address and friends were commented out in 5135.
Well I was kind of looking forward to the vbe debug. Hmm.
You'd still get some information from the debugging statements that work, but the statements referencing undefined variables are not likely to give you any good information.
Hello Pattrick. We made the CONFIG_DEBUG automatic.
------------------------- Author: myles Date: Fri Feb 19 20:08:11 2010 New Revision: 5131 URL: http://tracker.coreboot.org/trac/coreboot/changeset/5131
Log: 1. Change CONFIG_DEBUG to DEBUG in util/x86emu/* 2. Make DEBUG depend on CONFIG_YABEL_DEBUG_FLAGS being nonzero --------------------------------
Attached is a copy of my config.h for reference.
On 03/05/2010 05:21 AM, Stefan Reinauer wrote:
On 3/5/10 11:20 AM, Pattrick Hueper wrote:
Ah... very cool...
so Josephs issue with VBE debugging is resolved as well?
Patty
Worked for me... The X86EMU_DEBUG code may want some more tweaking to make it more silent / verbose with some of the flags, though
Ah, cool. I will try it out and let you know. I think a debugging menu is a great idea.
On 3/5/10 1:11 PM, Joseph Smith wrote:
You'd still get some information from the debugging statements that work, but the statements referencing undefined variables are not likely to give you any good information.
Hello Pattrick. We made the CONFIG_DEBUG automatic.
The code that was causing the errors in vbe.c was not being called, so no gain, just pain ;-) But it compiles anyways, now.
-
Joseph Smith -
Myles Watson -
Pattrick Hueper -
Stefan Reinauer