Re: [LinuxBIOS] r2815 - trunk/util/superiotool

[Stefan Reinauer]

[e-mail] wrote:
> De-uglify the --version output (trivial).
> 	printf("superiotool %s\n", SUPERIOTOOL_VERSION);
> 	strncpy((char *)&tmp,
> 		(const char *)&SUPERIOTOOL_VERSION[6],
> 		strlen(SUPERIOTOOL_VERSION) - 8);
> 	printf("superiotool r%s\n", (char *)&tmp);

Hm.. is this less uglier? Does it look trivial? ;)

Is there any reason that this doesnt just say

printf ("superiotool r" SUPERIOTOOL_VERSION "\n");

??

[LinuxBIOS] r2815 - trunk/util/superiotool

[Uwe Hermann]

On Mon, Oct 01, 2007 at 03:52:22PM +0200, Stefan Reinauer wrote:
> [e-mail] wrote:
> > De-uglify the --version output (trivial).
> > 	printf("superiotool %s\n", SUPERIOTOOL_VERSION);
> > 	strncpy((char *)&tmp,
> > 		(const char *)&SUPERIOTOOL_VERSION[6],
> > 		strlen(SUPERIOTOOL_VERSION) - 8);
> > 	printf("superiotool r%s\n", (char *)&tmp);
>
> Hm.. is this less uglier? Does it look trivial? ;)

OK, probably not trivial :) Guilty as charged.

It's less uglier (in the output), though:

Before:
./superiotool -v
superiotool r$Rev: 2814 $

After:
./superiotool -v
superiotool r2815
> Is there any reason that this doesnt just say
>
> printf ("superiotool r" SUPERIOTOOL_VERSION "\n");

Yes, it won't work unfortunately (I hoped it would, but it doesn't).

$Rev$ will not be replaced by the svn revision (e.g. "2815")
but rather by "$Rev: 2815 $" (which is stupid IMO, but we cannot change
that). It would be nice if there was something like $OnlyRev$ or so
which only prints the actual number, but I don't think there's such an
option.

Uwe.