Hey Ben,
please keep the discussion on the list. Thanks!
On Sun, Apr 29, 2007 at 05:27:29PM +0100, Ben Hewson wrote:
Hm, I don't know about this, this file is used with densitron/dpx114 also and it should also have this fixup in auto.c.
Does the densitron/dpx114 board still boot with the current version of LB ?
I don't know, but let's try not to make it any worse in any case.
Ben, is there really no way to have that register setting in the 8231 code in v2?
I can think of only 2 reasons why the write to register 0x42 does not work properly in ide_init(). Either it must be done before the IDE peripheral is enabled (it is disabled by default)
This makes sense.
or it is a timing issue.
Also possible, but mode before enable seems more likely.
If we move the fix from auto.c it would probably need to go before the IDE enable in vt8231_init(). At this point dev does not point to the correct PCI section, however the 2 lines of code in auto.c could be moved there.
Sure, finding the IDE device is neccessary.
Alternatively the IDE enable in vt8231_init() could be moved to ide_init(), but again dev does not then point to the correct PCI registers to enable the IDE.
Not sure which solution would be the most elegant. Do you have any preference ?
Not sure there is an elegant solution to this in v2 but I prefer the first solution, set compatibility mode before enabling IDE in _init.
//Peter
Peter Stuge wrote:
Hey Ben,
please keep the discussion on the list. Thanks!
On Sun, Apr 29, 2007 at 05:27:29PM +0100, Ben Hewson wrote:
Hm, I don't know about this, this file is used with densitron/dpx114 also and it should also have this fixup in auto.c.
Does the densitron/dpx114 board still boot with the current version of LB ?
I don't know, but let's try not to make it any worse in any case.
Ben, is there really no way to have that register setting in the 8231 code in v2?
I can think of only 2 reasons why the write to register 0x42 does not work properly in ide_init(). Either it must be done before the IDE peripheral is enabled (it is disabled by default)
This makes sense.
or it is a timing issue.
Also possible, but mode before enable seems more likely.
If we move the fix from auto.c it would probably need to go before the IDE enable in vt8231_init(). At this point dev does not point to the correct PCI section, however the 2 lines of code in auto.c could be moved there.
Sure, finding the IDE device is neccessary.
Alternatively the IDE enable in vt8231_init() could be moved to ide_init(), but again dev does not then point to the correct PCI registers to enable the IDE.
Not sure which solution would be the most elegant. Do you have any preference ?
Not sure there is an elegant solution to this in v2 but I prefer the first solution, set compatibility mode before enabling IDE in _init.
//Peter
Ok I'll try moving the code to vt8231_init() and see if it still runs.
Ben