Re: [coreboot] r836 - in coreboot-v3: arch/x86/amd/model_fxx mainboard/amd/serengeti

[Stefan Reinauer]

[e-mail] wrote:
> Author: rminnich
> Date: 2008-08-28 04:35:56 +0200 (Thu, 28 Aug 2008)
> New Revision: 836
>
> Added:
>    coreboot-v3/arch/x86/amd/model_fxx/dualcore_id.c
> Modified:
>    coreboot-v3/arch/x86/amd/model_fxx/init_cpus.c
>    coreboot-v3/mainboard/amd/serengeti/mainboard.h

Can you guys drop these printk redefinitions completely? They're a romcc
relict.
> Modified: coreboot-v3/arch/x86/amd/model_fxx/init_cpus.c
> ===================================================================
> --- coreboot-v3/arch/x86/amd/model_fxx/init_cpus.c	2008-08-28 02:32:27 UTC (rev 835)
> +++ coreboot-v3/arch/x86/amd/model_fxx/init_cpus.c	2008-08-28 02:35:56 UTC (rev 836)
> @@ -38,33 +38,33 @@
>  #define K8_SET_FIDVID 1
>
> #ifndef K8_SET_FIDVID_CORE0_ONLY
> -	/* MSR FIDVID_CTL and FIDVID_STATUS are shared by cores, so may don't need to do twice*/
> -       	#define K8_SET_FIDVID_CORE0_ONLY 1
> +	/* MSR FIDVID_CTL and FIDVID_STATUS are shared by cores, so may don't need to do twice */
> +#define K8_SET_FIDVID_CORE0_ONLY 1
>  #endif
>
> -static void print_initcpu8 (const char *strval, unsigned int val)
> +static void print_initcpu8(const char *strval, unsigned int val)
>  {
> -        printk(BIOS_DEBUG, "%s%02x\n", strval, val);
> +	printk(BIOS_DEBUG, "%s%02x\n", strval, val);
>  }
>
> -static void print_initcpu8_nocr (const char *strval, unsigned val)
> +static void print_initcpu8_nocr(const char *strval, unsigned val)
>  {
> -        printk(BIOS_DEBUG, "%s%02x", strval, val);
> +	printk(BIOS_DEBUG, "%s%02x", strval, val);
>  }
>
> -static void print_initcpu16 (const char *strval, unsigned val)
> +static void print_initcpu16(const char *strval, unsigned val)
>  {
> -        printk(BIOS_DEBUG, "%s%04x\n", strval, val);
> +	printk(BIOS_DEBUG, "%s%04x\n", strval, val);
>  }
>
> static inline void print_initcpu(const char *strval, unsigned val)
>  {
> -        printk(BIOS_DEBUG, "%s%08x\n", strval, val);
> +	printk(BIOS_DEBUG, "%s%08x\n", strval, val);
>
> }

r836 - in coreboot-v3: arch/x86/amd/model_fxx mainboard/amd/serengeti

[ron minnich]

On Wed, Aug 27, 2008 at 11:38 PM, Stefan Reinauer <[e-mail]> wrote:
> Can you guys drop these printk redefinitions completely? They're a romcc
> relict.

yes, I had been removing them until yesterday. Then I wondered if it
was a mistake to remove them, since they are kind of specialized, but
I agree: they need to be removed.

I will remove them in my next set of changes or the one after that.

ron