Re: K8 + 2.4.21 + Tyan S2880

[YhLu]

Ron,

I find the problem. Can you merge the diff the tree?

1. in raminit.c, when computing csbase, should recount from 0 for every
memory controllers. Otherwise the memory on second northbridge will not be
init properly and can not be used.

2. add start/stop notify function. ( in coherent_ht.c and auto.c)  Otherwise
when using image that was compiled in non debug mode for auto.c, the second
cpu can not be started.

Thanks.

Yinghai Lu

-----邮件原件-----
发件人: YhLu 
发送时间: 2003年7月23日 10:41
收件人: '[e-mail]'; 'ron minnich'; 'Stefan Reinauer'
抄送: '[e-mail]'
主题: Re: K8 + 2.4.21 + Tyan S2880

Eric or Ron or Stepfan,

To make the NIC under mem auto-conf code, I have spent one day on it. Here
are my findings:
1. Use the most updated code, in the Etherboot stage it will reboot after
firt NIC try aborting.
2. I have try to subsutite mem-conf with hard code version, and found
another problem, I can not start AP after conherent_ht or memory
initization. Only can start and stop in enable_routing function.
3. I have to move back to old code ( Before Eric moved some definition from
romcc_io.h to arch/io.h and cpu/p6/msr.h). At this situation, if I use
mem-conf, it still can not find broadcom nic in etherboot stage. But after I
substitute mem init with hard code one, It can find the nic.

I will study the difference today.

But anyway what make I can not start AP after conherent_ht or memory init,
so strange ???

Regards

Yinghai Lu

-----邮件原件-----
发件人: YhLu 
发送时间: 2003年7月22日 10:41
收件人: '[e-mail]'
抄送: ron minnich; Stefan Reinauer; [e-mail]
主题: Re: K8 + 2.4.21 + Tyan S2880

Eric,

It can be compiled with you new code. But it meet problems in Etherboot
stage.
In S2880 has two broadcom NIC port in 8131 bus B, and one amd 8111 built-in
nic, and even if I hide it in amd8111 init and Etherboot can find it and try
to enable it and can not find the PM cap so aborting, in the old linuxbios
code (before yesterday) ( with mem hard code), it will go to tickle on
Broadcom nic, but in the new code (yesterday check in) ( mem configurable),
it will go to MB restarting.???

How about arima broadcom nic position? 

Regards

Yinghai Lu

-----邮件原件-----
发件人: [e-mail] [mailto:[e-mail]] 
发送时间: 2003年7月21日 18:33
收件人: YhLu
抄送: ron minnich; Stefan Reinauer; [e-mail]
主题: Re: K8 + 2.4.21 + Tyan S2880

YhLu <[e-mail]> writes:
> Eric,
>
> In the auto.c, if I enable : sdram_initialize(&cpu1), the linuxbios need
> another 20k. What happened? Only add one line and the same function has
> been
> called ???

All functions are inline and the set of functions called is large.
At least I believe that is the issue.

And good luck catching up....

While I am away you get a chance.  My latest code has changed
sdram_initialize
one more time to take a cpu count parameter.

And perversely this should help because if a function is called in a loop
it will only be inlined once instead of multiple times.

Eric

K8 + 2.4.21 + Tyan S2880

[ron minnich]

Thank you for the patch. 

What I would like to do is get my linuxbios back to working condition, 
then merge these in. Otherwise, if Stefan can test and verify them, maybe 
he can merge them in before me. 

Thanks

ron

K8 + 2.4.21 + Tyan S2880

[Stefan Reinauer]

* ron minnich <[e-mail]> [030724 21:37]:
> Thank you for the patch.
>
> What I would like to do is get my linuxbios back to working condition, 
> then merge these in. Otherwise, if Stefan can test and verify them, maybe 
> he can merge them in before me.

I'm sitting at home and don't have access to any SMP K8 from here, so
I'm going to test (and commit) this tommorrow at work..

  Greetings,
     Stefan
-- 
Architecture Team
    SuSE Linux AG

K8 + 2.4.21 + Tyan S2880

[ron minnich]

OK, I'm back, the checked out tree works fine now. 

YhLu, I will try to commit your changes tomrrow.

ron

K8 + 2.4.21 + Tyan S2880

[ron minnich]

YhLu: I can fix your problem without adding the mainboard init function to 
hardware main, and also without code like this to the include file:

====
#ifdef FINAL_MAINBOARD_FIXUP
void final_mainboard_fixup(void);
#else
#  define final_mainboard_fixup() do {} while(0)
#endif /* FINAL_MAINBOARD_FIXUP */

====

All I need to do is add an enable function for the mainboard into the 
static device tree, and create a structure for your mainboard in the 
mainboard/tyan/2880 directory. This is pretty easy, and will let us test 
out the new static device support. 

But, if I make this change you are going to have to use the new config
tool for your mainboard. There is no going back to the old config tool
once I make the change.

The new config tool is working pretty well, now, however: Greg and Stefan 
and I are using it, and Greg and I use it exclusively. There are still 
some glitches here and there but overall it is quite solid.

Is this acceptable to you? Stefan, Greg, and I can help you with any
problems you encounter with the new config tool.

thanks

ron