Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1394
-gerrit
commit 33c63a50343c97963cd0111818619b1f00e43298 Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Thu Aug 2 09:44:03 2012 +0300
Siemens SiteMP: drop add_mainboard_resources()
Use of lb_add_memory_region() is reduntant with the MMCONF resource being set as reserved.
Change-Id: I747ea34823692b6966b2e50d22aea1fb89c73c25 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/mainboard/siemens/sitemp_g1p1/Kconfig | 1 - src/mainboard/siemens/sitemp_g1p1/mainboard.c | 20 -------------------- 2 files changed, 0 insertions(+), 21 deletions(-)
diff --git a/src/mainboard/siemens/sitemp_g1p1/Kconfig b/src/mainboard/siemens/sitemp_g1p1/Kconfig index b2cae03..dc761cf 100644 --- a/src/mainboard/siemens/sitemp_g1p1/Kconfig +++ b/src/mainboard/siemens/sitemp_g1p1/Kconfig @@ -14,7 +14,6 @@ config BOARD_SPECIFIC_OPTIONS # dummy select HAVE_MP_TABLE select HAVE_PIRQ_TABLE select HAVE_OPTION_TABLE - select HAVE_MAINBOARD_RESOURCES select HAVE_BUS_CONFIG select SB_HT_CHAIN_UNITID_OFFSET_ONLY select BOARD_ROMSIZE_KB_1024 diff --git a/src/mainboard/siemens/sitemp_g1p1/mainboard.c b/src/mainboard/siemens/sitemp_g1p1/mainboard.c index 905d23f..5053efa 100644 --- a/src/mainboard/siemens/sitemp_g1p1/mainboard.c +++ b/src/mainboard/siemens/sitemp_g1p1/mainboard.c @@ -856,26 +856,6 @@ static void enable_dev(device_t dev) dev->ops->init = init; // rest of mainboard init later }
- /** - * @brief - * - * @param - */ - -int add_mainboard_resources(struct lb_memory *mem) -{ - device_t dev; - struct resource *res; - - dev = dev_find_slot(0, PCI_DEVFN(0,0)); - res = probe_resource(dev, 0x1C); - if( res ) { - printk(BIOS_INFO, "mmconf: base=%0llx size=%0llx\n", res->base, res->size); - lb_add_memory_range(mem, LB_MEM_RESERVED, res->base, res->size); - } - return 0; -} - struct chip_operations mainboard_ops = { CHIP_NAME(CONFIG_MAINBOARD_PART_NUMBER) .enable_dev = enable_dev,