Dear coreboot folks,
currently there are three change sets up for review adding new Lenovo laptops based on the Intel GM45 chipset [1][2][3]. Most of them are very similar to the Lenovo X200, which is already in our tree.
One of the major differences between the Lenovo T* models is the HDA verb table. As these are currently included during compile time, all board files have to be copied [3] as Peter noted:
Patch Set 2: Code-Review-2
vendor BIOS provides different HDA verbs: coreboot of course needs to do that too. This should still be replaced with a separate port: yes exactly. please resubmit when that is done. Thanks!
It’d be great to have one image to support all these different models.
Is it feasible to put the HDA verb tables for the different models into CBFS and load the right one during run time? If such a model run time detection is not possible, then the corresponding HDA verb file could be added during the build process and the devices Lenovo R400 and T500 would just be clones of the Lenovo T400 for example with different HDA verbs.
Thanks,
Paul
[1] http://review.coreboot.org/9181 New mainboard: Lenovo T500 [2] http://review.coreboot.org/9316 mainboards/lenovo: Copy X200 board to T400 for future expansion [3] http://review.coreboot.org/8393 lenovo/r400: Add clone of Lenovo T400
One of the major differences between the Lenovo T* models is the HDA verb table.
Do we know that this is different between all of these models, or only between X200 and the other models? (I have seen a T400 photo with the audio connectors on front, unlike on X200, so some bits there differ between X200 and T400, but are the same on R400 and T400.)
Paul, would it work to name the verb tables by the vendor,device standard we use for vga bios and then be able to pick the right one?
e.g. hda8086,1234.tbl or some such?
On Sat, May 2, 2015 at 2:03 PM Michał Masłowski mtjm@mtjm.eu wrote:
One of the major differences between the Lenovo T* models is the HDA verb table.
Do we know that this is different between all of these models, or only between X200 and the other models? (I have seen a T400 photo with the audio connectors on front, unlike on X200, so some bits there differ between X200 and T400, but are the same on R400 and T400.) -- coreboot mailing list: coreboot@coreboot.org http://www.coreboot.org/mailman/listinfo/coreboot
-
mtjm＠mtjm.eu -
Paul Menzel -
ron minnich