Buildrom v3 config patch and qemu rename patch

[Myles Watson]

This patch changes buildrom for the renaming of qemu-i386 to qemu-x86.
 It also adds "make coreboot-v3-config" support ala Ward.  Ward, could
you check to make sure I didn't do something dumb when I shamelessly
copied you?

Thanks,
Myles

Signed-off-by: Myles Watson

[Ward Vandewege]

On Thu, Feb 07, 2008 at 01:33:38PM -0700, Myles Watson wrote:
> This patch changes buildrom for the renaming of qemu-i386 to qemu-x86.
>  It also adds "make coreboot-v3-config" support ala Ward.  Ward, could
> you check to make sure I didn't do something dumb when I shamelessly
> copied you?

Heh :) Looks good, but I would add $(CBV3_STAMP_DIR) as an order-only
prerequisite to the $(CBV3_STAMP_DIR)/.unpacked make target; otherwise doing
make coreboot-v3-config after make distclean is going to fail for a lack of
$(CBV3_STAMP_DIR).
> Signed-off-by: Myles Watson

With that change:

Acked-by: Ward Vandewege

Thanks,
Ward.

[Myles Watson]

> -----Original Message-----
> From: Ward Vandewege [mailto:[e-mail]]
> Sent: Thursday, February 07, 2008 1:44 PM
> To: Myles Watson
> Cc: Coreboot
> Subject: Re: Buildrom v3 config patch and qemu rename patch
>
> On Thu, Feb 07, 2008 at 01:33:38PM -0700, Myles Watson wrote:
> > This patch changes buildrom for the renaming of qemu-i386 to qemu-x86.
> >  It also adds "make coreboot-v3-config" support ala Ward.  Ward, could
> > you check to make sure I didn't do something dumb when I shamelessly
> > copied you?
>
> Heh :) Looks good, but I would add $(CBV3_STAMP_DIR) as an order-only
> prerequisite to the $(CBV3_STAMP_DIR)/.unpacked make target; otherwise
> doing
> make coreboot-v3-config after make distclean is going to fail for a lack
> of
> $(CBV3_STAMP_DIR).

Good catch.  Should we add that for uclibc as well?

Myles
> > Signed-off-by: Myles Watson
>
> With that change:
>
> Acked-by: Ward Vandewege
>
> Thanks,
> Ward.

[Myles Watson]

> > Heh :) Looks good, but I would add $(CBV3_STAMP_DIR) as an order-only
> > prerequisite to the $(CBV3_STAMP_DIR)/.unpacked make target; otherwise
> > doing
> > make coreboot-v3-config after make distclean is going to fail for a lack
> > of
> > $(CBV3_STAMP_DIR).
>
> Good catch.  Should we add that for uclibc as well?
>
> Myles

I was looking at the wrong line.  It was already in uclibc.

Rev 110.

Thanks,
Myles
> > > Signed-off-by: Myles Watson
> >
> > With that change:
> >
> > Acked-by: Ward Vandewege