#101: flashrom: Remove pciutils check from Makefile

[coreboot]

#101: flashrom: Remove pciutils check from Makefile
---------------------------------------------+------------------------------
   Reporter:  stuge                          |          Owner:  somebody     
       Type:  defect                         |         Status:  new          
   Priority:  major                          |      Milestone:  flashrom v1.0
  Component:  flashrom                       |        Version:               
   Keywords:  pciutils libpci build ldflags  |   Dependencies:               
Patchstatus:  patch needs review             |  
---------------------------------------------+------------------------------
 The check belongs in a configure script or similar, the check also claims
 that packages can not be found for any build error, which is not good
 enough. Has confused more than one user already.

-- 
Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/101>
coreboot <http://www.coreboot.org/>

[coreboot]

#101: flashrom: Remove pciutils check from Makefile
-------------------------+--------------------------------------------------
    Reporter:  stuge     |         Owner:  somebody                     
        Type:  defect    |        Status:  new                          
    Priority:  trivial   |     Milestone:  flashrom v1.0                
   Component:  flashrom  |       Version:                               
  Resolution:            |      Keywords:  pciutils libpci build ldflags
Dependencies:            |   Patchstatus:  patch needs review           
-------------------------+--------------------------------------------------
Changes (by stepan):

  * priority:  major => trivial


Comment:

 How is an external script different from the script that is already there?

 Just suggest a script. But you're suggesting to cut bread with a fork
 here.

-- 
Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/101#comment:1>
coreboot <http://www.coreboot.org/>

[coreboot]

#101: flashrom: Remove pciutils check from Makefile
-------------------------+--------------------------------------------------
    Reporter:  stuge     |         Owner:  stuge                        
        Type:  defect    |        Status:  new                          
    Priority:  trivial   |     Milestone:  flashrom v1.0                
   Component:  flashrom  |       Version:                               
  Resolution:            |      Keywords:  pciutils libpci build ldflags
Dependencies:            |   Patchstatus:  patch needs work             
-------------------------+--------------------------------------------------
Changes (by stuge):

  * owner:  somebody => stuge
  * patchstatus:  patch needs review => patch needs work


Comment:

 Fair enough, will work on patch.

-- 
Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/101#comment:2>
coreboot <http://www.coreboot.org/>

[coreboot]

#101: flashrom: Remove pciutils check from Makefile
-------------------------+--------------------------------------------------
    Reporter:  stuge     |         Owner:  stuge                        
        Type:  defect    |        Status:  new                          
    Priority:  trivial   |     Milestone:  flashrom 1.1                 
   Component:  flashrom  |       Version:                               
  Resolution:            |      Keywords:  pciutils libpci build ldflags
Dependencies:            |   Patchstatus:  patch needs work             
-------------------------+--------------------------------------------------
Changes (by stepan):

  * milestone:  flashrom v1.0 => flashrom 1.1


Comment:

 Moving this to 1.1

-- 
Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/101#comment:3>
coreboot <http://www.coreboot.org/>

[coreboot]

#101: flashrom: Remove pciutils check from Makefile
-------------------------+--------------------------------------------------
    Reporter:  stuge     |         Owner:  stuge                        
        Type:  defect    |        Status:  closed                       
    Priority:  trivial   |     Milestone:  flashrom v1.1                
   Component:  flashrom  |       Version:                               
  Resolution:  fixed     |      Keywords:  pciutils libpci build ldflags
Dependencies:            |   Patchstatus:  patch needs work             
-------------------------+--------------------------------------------------
Changes (by hailfinger):

  * status:  new => closed
  * resolution:  => fixed


Comment:

 This has been solved by making the libpci check conditional on actually
 needing libpci (i.e. not for the serial and USB and dummy flashers).

-- 
Ticket URL: <http://tracker.coreboot.org/trac/coreboot/ticket/101#comment:4>
coreboot <http://www.coreboot.org/>

[Peter Stuge]

coreboot wrote:
    * resolution:  => fixed
 
 Comment:
 
  This has been solved by making the libpci check conditional on actually
  needing libpci (i.e. not for the serial and USB and dummy flashers).
I disagree with this. The point was to create a configure script and
check for pciutils one time only.

But whatever.


//Peter

[Carl-Daniel Hailfinger]

On 16.01.2010 00:55, Peter Stuge wrote:
  coreboot wrote:
   
    * resolution:  => fixed

 Comment:

  This has been solved by making the libpci check conditional on actually
  needing libpci (i.e. not for the serial and USB and dummy flashers).
 I disagree with this. The point was to create a configure script and
 check for pciutils one time only.
I may have misunderstood the point of the bug in that case. Sorry about
that.

Quoting from the original bug description:
  the check also claims that packages can not be found
for any build
 error, which is not good enough.
The code changed months ago to fix this issue, and since that was 72% of
the bug description text, I felt it was appropriate to close the bug.


Side note: Last time I tried to split up Makefile into Makefile and
configure, there was strong opposition against that idea. I do listen to
others, and since it works for users right now (and is admittedly easier
to use), it is unlikely that such a split will happen.
Feel free to open a ticket for this, preferably in flashrom trac at
http://www.flashrom.org/trac/flashrom/newticket

Regards,
Carl-Daniel

-- 
Developer quote of the year:
"We are juggling too many chainsaws and flaming arrows and tigers."