On 1/23/10 5:43 PM, Samuel D. wrote:

I don't have any way to test this patch right now, so I'll just add it in upcoming 4.01.

 

Thanks for your work.

 

Sam.


Dear Sam,

there was an additional bug I introduced. On top of the other patch, you need to apply this:


Index: coreboot.c
===================================================================
--- coreboot.c    (revision 2775)
+++ coreboot.c    (working copy)
@@ -123,7 +123,8 @@
         /* if there is, all valid information is in the
          * referenced coreboot table
          */
-        head = __find_cb_table(forward->forward, 0x1000);
+        head = __find_cb_table(forward->forward,
+                forward->forward + 0x1000);
     }
 
     return head;

In addition I suggest to add the following patch:

Index: memsize.c
===================================================================
--- memsize.c    (revision 2775)
+++ memsize.c    (working copy)
@@ -125,7 +125,7 @@
         n++;
     }
     v->msegs = n;
-    cprint(LINE_INFO, COL_MMAP, "corebt");
+    cprint(LINE_INFO, COL_MMAP, "coreboot");
 }
 static void memsize_820()
 {


The other memory table types only output 6 characters here, but the field is 8 characters, so no need to abbreviate.
Sorry I didn't notice this earlier.

Best regards,
   Stefan


-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info@coresystems.dehttp://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866