On 3/29/10 10:01 PM, Myles Watson wrote:

On Mon, Mar 29, 2010 at 1:14 PM, Stefan Reinauer <stepan@coresystems.de> wrote:

This patch makes the assumption that the code doing the cmos choice has CONFIG_USE_OPTION_TABLE enabled.

Is this always the case?

I thought qemu checked CMOS values to know how much RAM there was, but didn't have USE_OPTION_TABLE set. It's been a long time since I looked at it, though.

I thought it would, but it seems it doesn't...

If it did, we should leave the cmos primitives always in, and only make the higher level funktions depend on USE_ or HAVE_OPTION_TABLE

-- 
coresystems GmbH • Brahmsstr. 16 • D-79104 Freiburg i. Br.
      Tel.: +49 761 7668825 • Fax: +49 761 7664613
Email: info@coresystems.de  • http://www.coresystems.de/
Registergericht: Amtsgericht Freiburg • HRB 7656
Geschäftsführer: Stefan Reinauer • Ust-IdNr.: DE245674866