Kyösti Mälkki (kyosti.malkki@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/299
-gerrit
commit 04ae610e7c83e6577cbc3043c747e54cea6b3fa7 Author: Kyösti Mälkki kyosti.malkki@gmail.com Date: Wed Oct 19 07:23:51 2011 +0300
IOAPIC: fix bitmask
APIC ID is bits 27..24, not 19..16.
Change-Id: Ib53a480bf4328901094ca2c4713e8317321962a1 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- src/arch/x86/lib/ioapic.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/arch/x86/lib/ioapic.c b/src/arch/x86/lib/ioapic.c index 3f64209..81d964c 100644 --- a/src/arch/x86/lib/ioapic.c +++ b/src/arch/x86/lib/ioapic.c @@ -79,7 +79,7 @@ void setup_ioapic(u32 ioapic_base, u8 ioapic_id) printk(BIOS_DEBUG, "IOAPIC: ID = 0x%02x\n", ioapic_id); /* Set IOAPIC ID if it has been specified. */ io_apic_write(ioapic_base, 0x00, - (io_apic_read(ioapic_base, 0x00) & 0xfff0ffff) | + (io_apic_read(ioapic_base, 0x00) & 0xf0ffffff) | (ioapic_id << 24)); }