hi Paul,

I think the patch does it the right way, we want to minimize the amount of conditionals in the devicetree, it's supposed to be a static representation of the board hardware. These are just FSP UPDs that are being set anyway.

In this case, the board ID is read from an EEPROM (CBI) by the EC, so I'm not sure that would be available early enough to conditionally set the devicetree params anyway.


On Tue, Apr 2, 2024 at 4:38 AM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
Dear coreboot folks,

Change-set *mb/google/nissa/var/craaskov: Disable external fivr* [1]
moves the settings for the external fully integrated voltage regulator
(FIVR) out of device tree/override tree to only apply it to board
revision with an external FIVR.

Is there a way to support conditions in device tree?

Kind regards,


[1]: https://review.coreboot.org/c/coreboot/+/81607
coreboot mailing list -- coreboot@coreboot.org
To unsubscribe send an email to coreboot-leave@coreboot.org