[coreboot] [PATCH] Re: LZMA magic number

[Ward Vandewege]

On Sat, Jan 26, 2008 at 02:18:39AM +0100, Carl-Daniel Hailfinger wrote:
> On 25.01.2008 18:58, Peter Stuge wrote:
> > On Fri, Jan 25, 2008 at 10:55:24AM -0700, Myles Watson wrote:
> > > I accidentally used an uncompressed payload with v2 when it
> > > expected a compressed payload, and it gave me the message:
> > >    Decoder scratchpad too small!!
> > >    Decoding error = 1
> >
> > I got this too.
> > > I think it would be nicer to have an error like:
> > >    Payload not compressed with lzma!
> >
> > And we can check it already at build time.
>
> LZMA compressed payloads to not have a magic number, all you can do is
> check if the header parameters are in a reasonable range. Sorry.
> This problem fortunately does not exist in v3 because LAR does the
> compression itself and notes the compression type in th header.

I ran into this runtime error as well today.

Please find a patch attached that makes coreboot a bit smarter in dealing
with this situation, and avoids the fatal runtime error.

Thanks,
Ward.