Re: [coreboot] [PATCH] errata#89 patch for Family 0Fh Prozessors

[Alex G.]

Can someone with commit access please commit this patch, or NACK it?

Alex

On 02/02/2011 11:55 PM, Alex G. wrote:
> That looks way better. :)
>
> Acked-by: Alexandru Gagniuc
>
> On 02/02/2011 10:17 PM, Josef Kellermann wrote:
> > Am 02.02.2011 20:11, schrieb Alex G.:
> > > Erratum 89 is already handled on line 390:
> > >
> > > if (!is_cpu_pre_b3()) {
> > > /* Erratum 89 ... */
> > > msr = rdmsr(NB_CFG_MSR);
> > > msr.lo |= 1 << 3;
> > >
> > > If this is also needed when CONFIG_K8_REV_F_SUPPORT == 1, then we should
> > > move the existing one out of the
> > > #if CONFIG_K8_REV_F_SUPPORT == 0
> > > so it gets executed in both cases, as opposed to duplicating it.
> > >
> > > Alex
> > >
> > > On 02/02/2011 07:39 PM, Josef Kellermann wrote:
> > > > This patch fixes a potential system hang.
> > > > Don't know why this patch isn't included if 'CONFIG_K8_REV_F_SUPPORT == 1'.
> > > >
> > > > Signed-off-by: Josef Kellermann  
> >
> > Ok,
> > now it gets executed in both cases.
> >
> > Signed-off-by: Josef Kellermann