Nico Huber (nico.huber@secunet.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1084
-gerrit
commit f1f1cbb111ff7a5b70d6a9baf1c75d28f70bffc1 Author: Mathias Krause mathias.krause@secunet.com Date: Tue May 29 14:28:26 2012 +0200
libpayload: fix OHCI IN commands
Due to operator precedence incomming USB commands were missing some flags.
Change-Id: I87ef51590c9db7a6cbc7304e1ccac29895f8a51e Signed-off-by: Mathias Krause mathias.krause@secunet.com --- payloads/libpayload/drivers/usb/ohci.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/payloads/libpayload/drivers/usb/ohci.c b/payloads/libpayload/drivers/usb/ohci.c index 730c540..4b3aa39 100644 --- a/payloads/libpayload/drivers/usb/ohci.c +++ b/payloads/libpayload/drivers/usb/ohci.c @@ -297,7 +297,7 @@ ohci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq, int dalen
while (pages > 0) { cur++; - cur->config = (dir==IN)?TD_DIRECTION_IN:TD_DIRECTION_OUT | + cur->config = (dir == IN ? TD_DIRECTION_IN : TD_DIRECTION_OUT) | TD_DELAY_INTERRUPT_NODELAY | TD_TOGGLE_FROM_ED | TD_CC_NOACCESS; @@ -324,7 +324,7 @@ ohci_control (usbdev_t *dev, direction_t dir, int drlen, void *devreq, int dalen }
cur++; - cur->config = (dir==IN)?TD_DIRECTION_OUT:TD_DIRECTION_IN | + cur->config = (dir == IN ? TD_DIRECTION_OUT : TD_DIRECTION_IN) | TD_DELAY_INTERRUPT_NODELAY | TD_TOGGLE_FROM_TD | TD_TOGGLE_DATA1 | @@ -392,7 +392,7 @@ ohci_bulk (endpoint_t *ep, int dalen, u8 *data, int finalize) }
for (cur = tds; cur->next_td != 0; cur++) { - cur->config = (ep->direction==IN)?TD_DIRECTION_IN:TD_DIRECTION_OUT | + cur->config = (ep->direction == IN ? TD_DIRECTION_IN : TD_DIRECTION_OUT) | TD_DELAY_INTERRUPT_NODELAY | TD_TOGGLE_FROM_ED | TD_CC_NOACCESS;