On Mon, Jul 20, 2009 at 8:14 AM, Rudolf Marek <r.marek@assembler.cz> wrote:

Hi Myles,

That's the way the rest of the boards did it. I'm sorry I missed this
southbridge. I thought I got them all.

Ok. Please prepare the patch.

Attached.

Signed-off-by: Myles Watson <mylesgw@gmail.com>

I noticed in your patch that you're setting the limit = base+size-1. The
limit is not the same as the end of the resource. For most I/O, the limit
should be 0xffff.

aha true. This was cut and paste from k8t890 where it was used to setup APIC resource. For mem resource it should be how? I don't understand the gran too.

The limit should always be the upper bound that a type of resource could be set to. For I/O 0xffff, for MEM, 0xffffffff...

gran sets the granularity of an allocation. For example, on K8 you have to allocate I/O to links at least 4K at a time, so the granularity is 12. gran and align should never matter for fixed resources.

For this SB (the VT8237S) we will definitely need to dynamically allocate a mmio BAR for SPI controller. I will prepare a patch, but cannot test.

I would like to ask if you care about the decoding range for flashes - if I need some other resource for that and also about 0xfee... for MSI.

Anything above 0xfec... doesn't matter, since you have an APIC resource there.

Thanks,
Myles