Re: [coreboot] [PATCH] ICH5: Add i82801ex_enable_rom() function

[Mark Marshall]

On 25/11/2010 09:11, Uwe Hermann wrote:
> See patch.

Hi.

All of the blocks of code you are removing to a config_u32 and a 
config_u8 write.  The code you've added does a config_u32 and a 
config_u16 write.  Is this correct?  Also the addresses that the writes 
go to are different - the removed code writes to 0xE8 and 0xF0 - your 
new code uses 0xE8 and 0xEE.

These are just comments from inspection of the diff.

MM