On Tue, Nov 11, 2008 at 8:24 PM, Myles Watson <mylesgw@gmail.com> wrote:

> -----Original Message-----
> From: ron minnich [mailto:rminnich@gmail.com]
> Sent: Tuesday, November 11, 2008 4:13 PM
> To: Marc Jones
> Cc: Myles Watson; Coreboot
> Subject: Re: [coreboot] Resource allocation
>

> On Tue, Nov 11, 2008 at 2:58 PM, Marc Jones <marcj303@yahoo.com> wrote:
>
> >
> > This would be a good reason to have a generic enable for each device
> like in v2. Then the enable function can handle anything. I am not sure
> how or why this changed in v3.
> >
>
> I thought you and I just finished getting this right. It's called
> phase3_setup_chip_dev. Is this not right? It does what the v2 thing
> did IIRC.

It goes through and allocates new devices and resources for each PNP device.
It doesn't read any of the dts information. That's the missing part.

I think I could add more fields to the struct that gets passed to the chip
enable and populate them from the dts. I just wasn't sure how you were
thinking it would work.

The other way to do it would be to add the PNP devices back into the dts. I personally think that's the way to go. If we put PNP devices around the configuration it won't be so huge, and the old PNP functions will work better again.

Was it deliberate that the devices disappeared?

Thanks,

Myles