On 8/27/10 4:24 PM, Jens Rottmann wrote:
me, somehow. This compiles and boots fine, but the 'register' statement still doesn't have any effect, sio_gp1x_config in the mainboard's chip.h still isn't set - hmm, tough luck ... Why have a struct mainboard_config if it can't be used? Maybe it should be removed completely??
That mechanism could be fixed to work correctly again. Attached patch should do that.
Tried chip mainboard / register ... in several locations but couldn't get it to work, sometimes it wouldn't compile or else the mainboard's enable_dev + init weren't called at all.
Patricks patch, plus this addition should do the job:
macpro:coreboot stepan$ svn diff Index: src/mainboard/lippert/spacerunner-lx/devicetree.cb =================================================================== --- src/mainboard/lippert/spacerunner-lx/devicetree.cb (revision 5745) +++ src/mainboard/lippert/spacerunner-lx/devicetree.cb (working copy) @@ -1,3 +1,7 @@ +chip mainboard/lippert/spacerunner-lx + +register "sio_gp1x_config" = "1" + chip northbridge/amd/lx device pci_domain 0 on device pci 1.0 on end # Northbridge @@ -88,3 +92,5 @@ end end end + +end
If it does not, we should fix the mechanism, independently of your use of Kconfig,...
Stefan