---

From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: "Li, Maggie" <Maggie.Li@amd.com>
Cc: Marc Jones <marcj303@gmail.com>; Dan Lykowski <engineerguy3737@yahoo.com>; coreboot@coreboot.org
Sent: Tuesday, February 3, 2009 8:20:17 PM
Subject: Re: [coreboot] SB600 HDA can't find codec fix

Hi Dan,

sorry for chasing you around in circles on that issue.

On 04.02.2009 05:14, Li, Maggie wrote:
> Dan
>
> I think you made a mistake. It should be “sm_dev = dev_find_device(PCI_VENDOR_ID_AMD, PCI_DEVICE_ID_ATI_SB600_SM, 0);”, not “sm_dev = pci_locate_device(PCI_ID(0x1002, 0x4385), 0);” in your file.
>
> In my last letter, there is a writing error. We should say that dev_find_device is more reliable than dev_find_slot
> 

I believe dev_find_device is indeed best. Anyway, I think I can make
that change locally and commit if you're OK with that.

Regards,
Carl-Daniel

> -----Original Message-----
> From: Carl-Daniel Hailfinger [mailto:c-d.hailfinger.devel.2006@gmx.net]
> Sent: Monday, February 02, 2009 10:26 AM
> To: Li, Maggie
> Cc: Dan Lykowski; Marc Jones; coreboot@coreboot.org
> Subject: Re: [coreboot] SB600 HDA can't find codec fix
>
> Hi Maggie,
>
> while your point about pci_find_device is valid, I think that
> dev_find_device is the function Dan should choose. It allows us to
> address the PCI devices even if their bus locations are shifted which is
> possible with some AMD chipsets and may also be true for boards with
> multiple chipsets.
> In general, we want to use functions which can deal with non-default bus
> topologies.
> 
--
http://www.hailfinger.org/


--
coreboot mailing list: coreboot@coreboot.org
http://www.coreboot.org/mailman/listinfo/coreboot