I agree.
The cache_as_ram_auto.c should be the same to all Opteron MB except for
1 spd rom related.
2 superio related
Other thing is need to consider apic id lifting.
So i consider change that to
#include "auto_1.c"
int someting spd and superio related
#include "auto_2.c"
YH
On 9/6/05, Eric W. Biederman <ebiederman@lnxi.com> wrote:
"Lu, Yinghai" <yinghai.lu@amd.com> writes:
> I tried to make cache_as_ram_auto.c more smaller, the problem is
> I can not use jmp __cpu_reset, and I need use goto cpu_reset_x
The practical problem was not how much the code had to do
(except for failover.c) but instead how little of that code
was in common functions, and instead was per-motherboard.
Implementing on one motherboard while experimenting is fine but when
you go multi-board too much cut and paste is dangerous.
The first round of dual core and cache as ram code feels
like an old style adventure game:
You have now entered a twisty maze of ifdefs.
Eric
--
LinuxBIOS mailing list
LinuxBIOS@openbios.org
http://www.openbios.org/mailman/listinfo/linuxbios