[coreboot] New patch to review for coreboot: ded4007 libpayload: Better error detection in USB mass storage

[Nico Huber]

Nico Huber ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/1072

-gerrit

commit ded400746b66ee42983c6a92e7490fd0a354ac53
Author: Nico Huber 
Date:   Mon May 21 14:05:41 2012 +0200

libpayload: Better error detection in USB mass storage

This implements status transport (CSW) more closely to the standard
    (usbmassbulk_10).

Change-Id: Ife516316e054d4e87ebe698dc487eeb9ebcfd38d
    Signed-off-by: Nico Huber 
---
 payloads/libpayload/drivers/usb/usbmsc.c |   26 +++++++++++++++++++-------
 1 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/payloads/libpayload/drivers/usb/usbmsc.c b/payloads/libpayload/drivers/usb/usbmsc.c
index 8d57736..e3ed3bb 100644
--- a/payloads/libpayload/drivers/usb/usbmsc.c
+++ b/payloads/libpayload/drivers/usb/usbmsc.c
@@ -151,8 +151,8 @@ get_max_luns (usbdev_t *dev)
    return luns;
 }

-int tag;
-int lun = 0;
+unsigned int tag;
+unsigned char lun = 0;

static void
 wrap_cbw (cbw_t *cbw, int datalen, cbw_direction dir, const u8 *cmd,
@@ -161,7 +161,7 @@ wrap_cbw (cbw_t *cbw, int datalen, cbw_direction dir, const u8 *cmd,
    memset (cbw, 0, sizeof (cbw_t));

cbw->dCBWSignature = cbw_signature;
-	cbw->dCBWTag = tag++;
+	cbw->dCBWTag = ++tag;
    cbw->bCBWLUN = lun;	// static value per device

cbw->dCBWDataTransferLength = datalen;
@@ -170,11 +170,22 @@ wrap_cbw (cbw_t *cbw, int datalen, cbw_direction dir, const u8 *cmd,
    cbw->bCBWCBLength = cmdlen;
 }

-static void
+static int
 get_csw (endpoint_t *ep, csw_t *csw)
 {
-	if (ep->dev->controller->bulk (ep, sizeof (csw_t), (u8 *) csw, 1))
+	if (ep->dev->controller->bulk (ep, sizeof (csw_t), (u8 *) csw, 1)) {
    	clear_stall (ep);
+		if (ep->dev->controller->bulk
+				(ep, sizeof (csw_t), (u8 *) csw, 1)) {
+			reset_transport (ep->dev);
+			return 1;
+		}
+	}
+	if (csw->dCSWTag != tag) {
+		reset_transport (ep->dev);
+		return 1;
+	}
+	return 0;
 }

static int
@@ -209,7 +220,8 @@ execute_command (usbdev_t *dev, cbw_direction dir, const u8 *cb, int cblen,
    		}
    	}
    }
-	get_csw (MSC_INST (dev)->bulk_in, &csw);
+	if (get_csw (MSC_INST (dev)->bulk_in, &csw))
+		return 1;
    if (always_succeed == 1) {
    	// return success, regardless of message
    	return 0;
@@ -219,7 +231,7 @@ execute_command (usbdev_t *dev, cbw_direction dir, const u8 *cb, int cblen,
    	reset_transport (dev);
    	return 1;
    }
-	if (csw.bCSWStatus == 0) {
+	if ((csw.bCSWStatus == 0) && (csw.dCSWDataResidue == 0)) {
    	// no error, exit
    	return 0;
    }