Re: [coreboot] [PATCH] Technexion TIM-5690

[Peter Stuge]

Hello, Thanks for the patch!

Libra Li wrote:
> --- src/mainboard/technexion/tim5690/mainboard.c    (revision 4821)

..
> -/***************************************************
> -* This board, the TIM-5690 has two Marvel 88e5056 PCI-E
> -* 10/100/1000 chips on board.
> -* Both of their pin PERSTn pins are connected to GPIO 5 of the
> -* SB600 southbridge.
> -****************************************************/
> -static void enable_onboard_nic()
> -{

Can you explain briefly why this code can be removed without loss of
functionality?

Is it simply not needed for this board?

Thanks!

//Peter