Re: [coreboot] New patch to review for coreboot: 1eb55d0 Add ASUS M4A785T-M mainboard support

[Paul Menzel]

Am Sonntag, den 27.11.2011, 18:59 +0100 schrieb Denis Carikli:
> Denis Carikli ([e-mail]) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/457
>
> -gerrit
>
> commit 1eb55d026f9d364eb8f3d7ededc4dc7f98deafef
> Author: Denis 'GNUtoo' Carikli 
> Date:   Sun Nov 27 15:58:38 2011 +0100
> Add ASUS M4A785T-M mainboard support
>
> This mainboard is very similar to the M4A785-M, but it has
>   DDR3 instead of DDR2.
>
> That's why most of the code was copied or included from
>   the m4a785-m directory
>
> Notable changes between the two mainboards include:
>  * the selection of the last microcode (mc_patch_010000b6.h)
>    which made it pass the CPU init.
>  * the selection of DDR3 which made it pass the ram init

Thank you very much for the patch.

Could you add what you have tested and not, what works and what does not
(flickering)? The OS you tested with. You need to add pci=nocrs
currently to the command line if I remember correctly.

You have a Wiki page already. Could you add the URL to this page too?
Also URLs to messages in the list archives with the boot log and for
example `dmesg`.
> Change-Id: I5df0bc1f9f0071b1e1ee7c8a356bf517aa8cf732
> Signed-off-by: Denis 'GNUtoo' Carikli <[e-mail]>

[…]

Thanks,

Paul