On Tue, May 18, 2010 at 09:37:49PM -0400, Keith Hui wrote:
A number of cleanups for 440BX raminit code.
Signed-off-by: Keith Hui firstname.lastname@example.org
Thanks, r5820 with some minor changes.
- Bits referencing empty rows are ?don?t care?.
that looks odd...
That is straight from the 440BX datasheet.
I think Stefan meant the funny characters (displayed as "?" here in my mailer) not the "don't care" wording itself. I fixed that in the commit.
- /* TODO: Set SDRAMC. */
- pci_write_config16(NB, SDRAMC, 0x0010); /* SDRAMPWR=1: 4 DIMM config */
This part is deleted without a replacement. Is it not needed? Is this set somewhere else?
Set somewhere else. It is now an entry in the register_values array. Value is set conditionally at compile time by CONFIG_SDRAMPWR_4DIMM.
Yep, confirmed. Without this hunk all 3-DIMM-slot boards would not boot, confirmed on at least the ASUS P2B and A-Trend ATC-6220.