Re: [coreboot] [PATCH 1/4] Geode GX2 auto DRAM detect patch V2

[Uwe Hermann]

On Sun, Oct 31, 2010 at 10:57:51PM +0100, Nils wrote:
> This patch changes the MSR register numbers in to more descriptive names.
>
> Signed-off-by: Nils Jacobs <[e-mail]>

Thanks, r6008.

I cross-checked against the datasheet and gx2def.h.
> /* 3. release CKE mask to enable CKE */
> -	msr = rdmsr(0x2000001d);
> +	msr = rdmsr(MC_CFCLK_DBUG);
>   msr.lo &= ~(0x03 << 8);
> -	wrmsr(0x2000201d, msr);
> +	wrmsr(MC_CFCLK_DBUG, msr);

Heh, fun. This was a bug anyway (0x2000001d vs. 0x2000201d).


Uwe.
-- 
http://hermann-uwe.de     | http://sigrok.org
http://randomprojects.org | http://unmaintained-free-software.org