Re: [coreboot] PATCH: Add code to initialize PIIX4 ACPI/PM/SMBus device

[Stefan Reinauer]

On 3/29/10 4:43 AM, Keith Hui wrote:
> This is required for properly placing the I/O ports for power
> management functionalities, which in turn will be required for future
> ACPI work. Speaking of which, I based these ports at 0xe400, after my
> P2B-LS board.

That is problematic. Can you put it below 0x1000? IO ports 0x1000 and
above are maintained by the register allocator and thus there may be
conflicts, depending on what PCI cards you plug into that system.
> One other change I should propose (but is not in this patch) is that
> the definition for SMBUS_IO_BASE be moved to i82371eb.h from
> i82371eb_early_smbus.c.
>  Makes more sense for a definition that may be
> referenced from some other places.

Yes, absolutely.

Stefan